stream pipeline kills process when writeStream is closed

Version

v21.7.1

Platform

Linux

Subsystem

No response

What steps will reproduce the bug?

To reproduce this follow this

echo "Hello from src file" > /tmp/src.txt

Now run this script

//@ts-check

const fs = require('node:fs')
const { pipeline } = require('node:stream/promises')
const { promisify } = require('node:util')

const main = async () => {
  const dst = '/tmp/dest.txt'
  const writeStream = fs.createWriteStream(dst, { flags: 'a' })

  const close = promisify(writeStream.close)
  await close.call(writeStream)

  console.log(writeStream.closed, writeStream.writableEnded)

  await pipeline(fs.createReadStream('/tmp/src.txt'), writeStream)
  const dstfile = await fs.promises.readFile(dst, { encoding: 'utf8' })
  console.log({ dstfile })
}

main()
  .then(() => {
    console.log('done')
  })
  .catch((err) => {
    console.log('error')
    console.error(err)
  })
  .finally(() => {
    console.log('over')
  })

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

pipeline function should throw error saying writeStream is closed.

What do you see instead?

prints true true then exits with code 0. true true is part of script and its working as intended.

Additional information

No response

@ronag

@ronag wdyt?

(also weren't we deprecating close?)

Yea. I think we should throw if pipelining to a destroyed or ended stream. However, that will be semver major.

Yes definitely semver-major and I agree it's better behavior conceptually

@ronag

Hi guys, I'd like to take some time to work on this issue, @ronag may I ask what should be the error code for this one if we decide to throw an error?

I think we have ERR_STREAM_CANNOT_PIPE that sounds really close

E('ERR_STREAM_CANNOT_PIPE', 'Cannot pipe, not readable', Error);

But I think this one probably should be something like Cannot pipe, the stream has already ended / destroyed / closed.

Being said should I add new error code(s) or there is an existing one that fits the purpose.

stream: pipe to a closed or destroyed stream is not allowed in pipeline

Navigation Menu

Repository navigation

stream pipeline kills process when writeStream is closed #52622

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

stream pipeline kills process when writeStream is closed #52622

Description

Version

Platform

Subsystem

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior? Why is that the expected behavior?

What do you see instead?

Additional information

Activity

benjamingr commented on Apr 24, 2024

benjamingr commented on Apr 24, 2024

ronag commented on Apr 25, 2024

benjamingr commented on Apr 25, 2024

jakecastelli commented on May 31, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions