Skip to content

Please add latest brotli 1.1.0 bindings with compression dictionary support #52250

Description

@nhelfman

What is the problem this feature will solve?

Current node brotli compression does not support compression dictionary.
The dictionary option only supported for deflate/inflate according to documentation:

dictionary | | | (deflate/inflate only, empty dictionary by default)

This prevents using node.js directly to create compression dictionary diffs at build time which is necessary in order to adopt Compression dictionary transport

What is the feature you are proposing to solve the problem?

Add latest code/binaries and binding to compression options to support latest brotli (https://github.com/google/brotli) version 1.1.0 so that we can use the dictionary option in brotli.

cc: @benjamingr

What alternatives have you considered?

No response

Activity

  1. added
    brotliIssues and PRs related to the Brotli dependency.
    on Mar 30, 2024
  2. benjamingr commented on Apr 1, 2024

    @benjamingr
    Member

    @nodejs/zlib it looks like this just needs exposing in the API JS side

  3. juanarbol commented on Apr 2, 2024

    @juanarbol
    Member

    I can work on this :-)

  4. self-assigned this
    on Apr 2, 2024
  5. MarshallOfSound commented on Jun 26, 2024

    @MarshallOfSound
    Member

    @juanarbol is this in flight somewhere, would love to poke at a dev branch or something 🤔 Poking at the compression dictionary transport tech and built in bindings would make this a lot easier 😅

    Happy to help out with the change too 🥳

  6. moved this from Awaiting Triage to Triaged in Node.js feature requestson Jun 26, 2024
  7. github-actions commented on Dec 24, 2024

    @github-actions
    Contributor

    There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Issues and PRs exempt from automated stale handling. label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
    For more information on how the project manages feature requests, please consult the feature request management document.

  8. added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Dec 24, 2024
  9. github-actions commented on Jan 24, 2025

    @github-actions
    Contributor

    There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

    For more information on how the project manages feature requests, please consult the feature request management document.

  10. alex-statsig commented on Feb 4, 2025

    @alex-statsig

    @juanarbol / @avivkeller is there any update on this elsewhere? Seems like this was planned

  11. valiantvu commented on Jun 24, 2025

    @valiantvu

    Can we reopen this issue? We're looking into using compression dictionaries at Pinterest and would love to see this natively supported in Node.

  12. MarshallOfSound commented on Jun 24, 2025

    @MarshallOfSound
    Member

    @valiantvu I built this out at Notion, I will note that brotli based compression is slow enough that even with CDN caching doing it on the fly wasn't great. Doing zstd based dictionary compression is 10/10 though, unfortunately there isn't good node support for that either 😆

    I ended up building a rust-based lambda for dictionary compresison which was fronted by {insert_cdn_here}. It did zstd dictionary compression on the fly and was lightweight enough to be super quick. I'd suggest some kind of system similar to that if you're exploring options here.

  13. removed their assignment
    on Dec 21, 2025
  14. juanarbol commented on Dec 21, 2025

    @juanarbol
    Member

    Can we reopen this issue? We're looking into using compression dictionaries at Pinterest and would love to see this natively supported in Node.

    Hey @valiantvu, do you think Pinterest can sponsor this? If so, feel free to reach out in my email.

  15. removed
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Dec 21, 2025
  16. rokob commented on Feb 10, 2026

    @rokob
    Contributor

    Howdy, I noticed this issue seemed stalled so I took a go at it: #61763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    brotliIssues and PRs related to the Brotli dependency.feature requestIssues requesting new Node.js features.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions