Avoid calling curl from tests

Adding so I don't forget -- we currently invoke curl in two tests which implicitly pulls it as a dependency:

$ ag "curl " test
test/parallel/test-http-304.js
13:  childProcess.exec('curl -i http://127.0.0.1:' + common.PORT + '/',

test/parallel/test-http-curl-chunk-problem.js
19:  console.log('making curl request');
20:  var cmd = 'curl http://127.0.0.1:' + common.PORT + '/ | ' +

Suggesting we replace this with.. javascript?

curl isn't the only unix util in the tests, there's sed, tail, grep, cat and probably more, which is why we have "git bash" as one of the recommended prerequisites for setting up a dev environment. curl does have the nice side effect of validating Node's HTTP server implementation. Having said that, I don't think I'd object to someone writing a replacement in common.js for it.

On the two tests in question:

what is test/parallel/test-http-304.js even testing? It's not clear to me that it's got anything to do with 304 other than "I can set a 304 status code and not kill my http server".
test/parallel/test-http-curl-chunk-problem.js is piping curl output to openssl-cli at the heart of the test and there's a link pointing to https://groups.google.com/forum/#!topic/nodejs/9mzTyWBAaRk which implicates curl as a problematic client for node (hence the name of the test I think). So maybe it's not such a good target for rewriting although it could have a bail-if-no-curl clause like we do with common.opensslCli.

curl lives outside of coreutils or what for instance busybox would offer (it has the other examples you brought up) hence my suggestion. I didn't really look into this other than running into the 'missing dependency' issue; the plan was to have a look at it a bit later.

Looking into

test-http-304; pretty pointless; not even checking status code or an empty body.
test-http-curl-chunk-problem.js; author suggests that more clients has the same issue, but its pretty obvious that curl is what we're after.

I'm not particularly keen on growing the common.js-convention of hasThis/isThat, but I'd take a skip over fail any day.

cc @nodejs/testing

I'd be up for trying to get this done if we want to do it

test: remove the use of curl in the test suite

Navigation Menu

Repository navigation

Avoid calling curl from tests #5174

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Avoid calling curl from tests #5174

Description

Activity

rvagg commented on Feb 10, 2016

jbergstroem commented on Feb 10, 2016

orangemocha commented on Feb 11, 2016

MylesBorins commented on Feb 11, 2016

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions