Skip to content

test_runner: differentiate describe from it in event:enqueue so we can have a total test count #51235

Description

@icetbr

What is the problem this feature will solve?

I have 10.000 tests that run in 10 minutes. I want to have a sense of progress.

What is the feature you are proposing to solve the problem?

Add the type of the test to the enqueue event might be enough, whether it is a test or a test group; it vs describe.

What alternatives have you considered?

No response

Activity

  1. MoLow commented on Dec 23, 2023

    @MoLow
    Member

    are you interested on opening a PR for this?

  2. added
    good first issueIssues that are suitable for first-time contributors.
    test_runnerIssues and PRs related to the test runner subsystem.
    on Dec 23, 2023
  3. icetbr commented on Dec 23, 2023

    @icetbr
    Author

    Sure! There is already the type in some events, hopefully I just have to use the same logic. Should I proceed?

  4. Medhansh404 commented on Jan 1, 2024

    @Medhansh404

    @MoLow i have gone through the issue and what i came up with the approach of adding the type of event along with emit('enqueue', { test: ${i}, testType }); here on each iteration for tests. I can open a PR if you can confirm if this can be a way to solve things here. would appreciate the feedback!! :)

  5. MoLow commented on Jan 2, 2024

    @MoLow
    Member

    yes ,that makes sense

  6. Medhansh404 commented on Jan 3, 2024

    @Medhansh404

    as i am working on the issue i can no longer find the significance of type of test rather we can do a log of no. of completed test out of total test, which we can increment on each completed test here, i find this better. what do you think @icetbr @MoLow ?

  7. icetbr commented on Jan 3, 2024

    @icetbr
    Author

    I can't tell if that will work. The current events make it impossible to distinguish between a describe and an it. If that will help with a 30 out of 10000 tests situation, I'm fine with that.

  8. github-actions commented on Jul 2, 2024

    @github-actions
    Contributor

    There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Issues and PRs exempt from automated stale handling. label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
    For more information on how the project manages feature requests, please consult the feature request management document.

  9. added
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Jul 2, 2024
  10. EddieAbbondanzio commented on Jul 23, 2024

    @EddieAbbondanzio
    Contributor

    I'm gonna pick this up since it seems to be stale.

  11. removed
    staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.
    on Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature requestIssues requesting new Node.js features.good first issueIssues that are suitable for first-time contributors.test_runnerIssues and PRs related to the test runner subsystem.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions