test-domain-error-types crashes on macOS in debug build

[targos]

$ out/Debug/node --gc-interval=100 --stress-compaction /Users/mzasso/git/nodejs/node/test/parallel/test-domain-error-types.js


#
# Fatal error in ../../deps/v8/src/heap/heap-write-barrier.cc, line 26
# Debug check failed: (marking_barrier) != nullptr.
#
#
#
#FailureMessage Object: 0x16f836518
----- Native stack trace -----

 1: 0x1006ed9c8 node::DumpNativeBacktrace(__sFILE*) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 2: 0x10092203c node::NodePlatform::GetStackTracePrinter()::$_3::operator()() const [/Users/mzasso/git/nodejs/node/out/Debug/node]
 3: 0x100921ff8 node::NodePlatform::GetStackTracePrinter()::$_3::__invoke() [/Users/mzasso/git/nodejs/node/out/Debug/node]
 4: 0x1027cfb3c V8_Fatal(char const*, int, char const*, ...) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 5: 0x1027cf6d8 std::__1::enable_if<!std::is_function<std::__1::remove_pointer<char>::type>::value && !std::is_enum<char>::value && has_output_operator<char, v8::base::CheckMessageStream>::value, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>::type v8::base::PrintCheckOperand<char>(char) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 6: 0x101042768 v8::internal::WriteBarrier::CurrentMarkingBarrier(v8::internal::Tagged<v8::internal::HeapObject>) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 7: 0x101042868 v8::internal::WriteBarrier::MarkingSlow(v8::internal::Tagged<v8::internal::HeapObject>, v8::internal::FullHeapObjectSlot, v8::internal::Tagged<v8::internal::HeapObject>) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 8: 0x100c11e8c v8::Private::New(v8::Isolate*, v8::Local<v8::String>) [/Users/mzasso/git/nodejs/node/out/Debug/node]
 9: 0x1007155c4 node::IsolateData::CreateProperties() [/Users/mzasso/git/nodejs/node/out/Debug/node]
10: 0x10071eacc node::IsolateData::IsolateData(v8::Isolate*, uv_loop_s*, node::MultiIsolatePlatform*, node::ArrayBufferAllocator*, node::SnapshotData const*) [/Users/mzasso/git/nodejs/node/out/Debug/node]
11: 0x10071f0e0 node::IsolateData::IsolateData(v8::Isolate*, uv_loop_s*, node::MultiIsolatePlatform*, node::ArrayBufferAllocator*, node::SnapshotData const*) [/Users/mzasso/git/nodejs/node/out/Debug/node]
12: 0x100640504 node::CreateIsolateData(v8::Isolate*, uv_loop_s*, node::MultiIsolatePlatform*, node::ArrayBufferAllocator*, node::EmbedderSnapshotData const*) [/Users/mzasso/git/nodejs/node/out/Debug/node]
13: 0x1008adb2c node::NodeMainInstance::NodeMainInstance(node::SnapshotData const*, uv_loop_s*, node::MultiIsolatePlatform*, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>> const&) [/Users/mzasso/git/nodejs/node/out/Debug/node]
14: 0x1008add94 node::NodeMainInstance::NodeMainInstance(node::SnapshotData const*, uv_loop_s*, node::MultiIsolatePlatform*, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>> const&) [/Users/mzasso/git/nodejs/node/out/Debug/node]
15: 0x1007a1744 node::StartInternal(int, char**) [/Users/mzasso/git/nodejs/node/out/Debug/node]
16: 0x1007a1394 node::Start(int, char**) [/Users/mzasso/git/nodejs/node/out/Debug/node]
17: 0x1022681c4 main [/Users/mzasso/git/nodejs/node/out/Debug/node]
18: 0x18157d0e0 start [/usr/lib/dyld]
[1]    61167 trace trap  out/Debug/node --gc-interval=100 --stress-compaction

[targos]

Like in #50726, this happens (or is more likely to happen) when node is configured with --node-builtin-modules-path=$(pwd)

[joyeecheung]

It seems strange that --node-builtin-modules-path makes a difference here because from the stack trace it crashed before any JS code was executed.

I think this looks like a missing Isolate::Scope somewhere, which may have been caught by #50680

[targos]

I can't reproduce anymore with current main.