Skip to content

tools: update-icu.sh is broken #50498

Closed
Closed
tools: update-icu.sh is broken#50498
Labels
good first issueIssues that are suitable for first-time contributors.toolsIssues and PRs related to the tools directory.

Description

@marco-ippolito
marco-ippolito
opened on Nov 1, 2023

Refs: #50495
Somehow the script is not getting the new version correctly and updating maintaining-dependencies.md

Activity

  1. marco-ippolito
    added
    good first issueIssues that are suitable for first-time contributors.
    toolsIssues and PRs related to the tools directory.
    on Nov 1, 2023

  2. targos commented on Nov 1, 2023

    @targos
    targos
    on Nov 1, 2023
    Member

    There's no .md5 file in the assets for version 74.1
    https://github.com/unicode-org/icu/releases/tag/release-74-1
    https://github.com/unicode-org/icu/releases/tag/release-73-2

  3. targos commented on Nov 1, 2023

    @targos
    targos
    on Nov 1, 2023
    Member

    Should we use the .asc file instead?

  4. targos commented on Nov 1, 2023

    @targos
    targos
    on Nov 1, 2023
    Member

    @srl295 Is it expected that we don't find the md5 files anymore?

  5. marco-ippolito commented on Nov 1, 2023

    @marco-ippolito
    marco-ippolito
    on Nov 1, 2023
    MemberAuthor

    Should we use the .asc file instead?

    I think this is the fastest solution

  6. srl295 commented on Nov 1, 2023

    @srl295
    srl295
    on Nov 1, 2023
    Member

    May be an oversight.

    @markusicu @pedberg-icu ?

  7. richardlau commented on Nov 1, 2023

    @richardlau
    richardlau
    on Nov 1, 2023
    Member

    I've opened an upstream issue: https://unicode-org.atlassian.net/jira/software/c/projects/ICU/issues/ICU-22567

  8. markusicu commented on Nov 1, 2023

    @markusicu
    markusicu
    on Nov 1, 2023

    Fixed. @mihnita

    • Created and uploaded icu4c-74_1-src.md5
    • Renamed icu4c-74_1_binary.md5 to icu4c-74_1-binary.md5, to match 73_2
    • Removed icu4j-74.1.md5 from 73_2

  9. srl295 commented on Nov 1, 2023

    @srl295
    srl295
    on Nov 1, 2023
    Member

    Is the build script able to use release candidate tarballs?

  10. islandryu
    added a commit that references this issue on May 20, 2024

    tools: verify with gpg if md5 is not present in update-icu

    a95ea15

  11. marco-ippolito commented on Oct 6, 2024

    @marco-ippolito
    marco-ippolito
    on Oct 6, 2024
    MemberAuthor

    it seems to be working fine now #52573

  12. marco-ippolito
    closed this as completedon Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions