Repository navigation
V8 patch update workflow is broken #50497
Description
Activity
Could it be a timeout?
It's failing consistently
cc @nodejs/security-wgNote it doesn't fail on my computer:
$ ./tools/dep_updaters/update-v8-patch.sh Skipped because V8 is on the latest version.Yes, it's been failing consistently for some time.
Here are the commits between the last successful run and the first failure: 718f62b...ff14b24Note it doesn't fail on my computer:
$ ./tools/dep_updaters/update-v8-patch.sh Skipped because V8 is on the latest version.same for me, I can create a branch and remove the pipe to temp output so we should see in the action as it runs
./tools/dep_updaters/update-v8-patch.sh
> temp-outputhttps://github.com/nodejs/node/actions/runs/6717612045/job/18255788737
with this change (./tools/dep_updaters/update-v8-patch.sh >temp-output), it works 🤔
main...do-not-merge/fix-update-v8-actionCan you try again with
echostatements between each line so we have an idea about when it fails?now it worked on main 🤔
https://github.com/nodejs/node/actions/workflows/update-v8.yml
that's 100% weird, on other branch it worked fine too
could begit node v8 minorfailing network calls?Could be related to nodejs/node-core-utils#722 😞
Reacted by Marco IppolitoNot sure. It's been failing consistently since June.
Now there's an update and it fails: https://github.com/nodejs/node/actions/runs/6945894914/job/18896335828
@targos should we add some logging to the script/action?
Probably.
@nodejs/node-core-utils
maybe related to nodejs/node-core-utils#743, it also fails for git node v8 minor
The fails seems not to be consistent anymore but using a previous version 3.3.0 gives an output
https://github.com/nodejs/node/actions/runs/7016406093/job/19087566216
while using >4.0.0 no error messageOk, so the ncu bug is that it swallows the error message.
The problem of the workflow is that it doesn't set Git name and email before running the update script.Reacted by Marco Ippolito4 remaining items
Still broken after #52822:
https://github.com/nodejs/node/actions/runs/8958621255/job/24603051286
Error: Command failed with exit code 1 (EPERM): git commit -m 'Update from 'Create or Update Request' action' --author 'Node.js GitHub Bot <github-bot@iojs.org>'Looks like the commit message is not correctly escaped (
git commit -m 'Update from 'Create or Update Request' action'), related to gr2m/create-or-update-pull-request-action#280- added a commit that references this issue
on May 5, 2024 - added 2 commits that reference this issue
on May 8, 2024 - added 2 commits that reference this issue
on Jun 17, 2024 - added 2 commits that reference this issue
on Jun 20, 2024
See https://github.com/nodejs/node/actions/runs/6680065519/job/18152806998
It's not clear why it fails. There's no error message in the output.
/cc @marco-ippolito