Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android build failed #49739

Closed
MatteoBax opened this issue Sep 20, 2023 · 6 comments · Fixed by #49744
Closed

Android build failed #49739

MatteoBax opened this issue Sep 20, 2023 · 6 comments · Fixed by #49744
Labels
android Issues and PRs related to the android platform. build Issues and PRs related to build files or the CI.

Comments

@MatteoBax
Copy link
Contributor

MatteoBax commented Sep 20, 2023 •
edited by RaisinTen
Loading

Hi,
when I try to build Node.js (version 20.7.0) for the Android platform I get:

./android-configure /workspaces/codespaces-blank/android-ndk-r26 31 aarch64
Node.js android configure: Found Python 3.10.8...
Info: Configuring for arm64...
Node.js configure: Found Python 3.10.8...
WARNING: --openssl-no-asm will result in binaries that do not take advantage
         of modern CPU cryptographic instructions and will therefore be slower.
         Please refer to BUILDING.md
WARNING: warnings were emitted in the configure phase
INFO: configure completed successfully

make -j4 
make[1]: *** No rule to make target '/workspaces/codespaces-blank/node-v20.7.0/out/Release/obj.host/libuv/deps/uv/src/unix/pthread-fixes.o', needed by '/workspaces/codespaces-blank/node-v20.7.0/out/Release/obj.host/deps/uv/libuv.a'.  Stop.
make[1]: *** Waiting for unfinished jobs....
  /workspaces/codespaces-blank/android-ndk-r26/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android31-clang -o /workspaces/codespaces-blank/node-v20.7.0/out/Release/obj.host/libuv/deps/uv/src/unix/procfs-exepath.o ../deps/uv/src/unix/procfs-exepath.c '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_HAS_QUIC' '-DICU_NO_USER_DATA_OVERRIDE' '-D__STDC_FORMAT_MACROS' '-DOPENSSL_NO_PINSHARED' '-DOPENSSL_THREADS' '-DOPENSSL_NO_ASM' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-D_GNU_SOURCE' -I../deps/uv/include -I../deps/uv/src  -msign-return-address=all -Wall -Wextra -Wno-unused-parameter -fvisibility=hidden -g --std=gnu89 -Wall -Wextra -Wno-unused-parameter -Wstrict-prototypes -fno-strict-aliasing -pthread -O3 -fno-omit-frame-pointer -fPIC  -MMD -MF /workspaces/codespaces-blank/node-v20.7.0/out/Release/.deps//workspaces/codespaces-blank/node-v20.7.0/out/Release/obj.host/libuv/deps/uv/src/unix/procfs-exepath.o.d.raw   -c
make: *** [Makefile:134: node] Error 2

How can I solve it?
@tniessen tniessen added build Issues and PRs related to build files or the CI. android Issues and PRs related to the android platform. labels Sep 20, 2023
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Sep 21, 2023
@bnoordhuis
deps: remove pthread-fixes.c from uv.gyp
aa48cd9 
The file was removed in the latest libuv upgrade. Remove it from the
build recipe as well.

Fixes: nodejs#49739
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Sep 21, 2023
@bnoordhuis
deps: remove pthread-fixes.c from uv.gyp
56c8dfb 
The file was removed in the latest libuv upgrade. Remove it from the
build recipe as well.

Fixes: nodejs#49739
@bnoordhuis bnoordhuis mentioned this issue Sep 21, 2023
Merged
@bnoordhuis
Copy link
Member

Here you go: #49744

@MatteoBax
Copy link
Contributor Author

MatteoBax commented Sep 21, 2023 •
edited
Loading

I edited the "deps/uv/uv.gyp" file as described in the pull request #49744 but now the problem is:

../deps/zlib/cpu_features.c:43:10: fatal error: 'cpu-features.h' file not found
#include <cpu-features.h>
         ^~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [deps/zlib/zlib.target.mk:127: /workspaces/codespaces-blank/node/out/Release/obj.target/zlib/deps/zlib/cpu_features.o] Error 1
make[1]: *** Waiting for unfinished jobs....
rm ba2e713c65e96ba2093f69b541eaf18cf990bba7.intermediate baa44214685e5f3e204d864ab741a526ee533e52.intermediate
make: *** [Makefile:134: node] Error 2

The file "/workspaces/codespaces-blank/android-ndk-r26/sources/android/cpufeatures/cpu-features.h" exist.

@bnoordhuis
Copy link
Member

There's something wrong with your local copy, that's not the deps/zlib/cpu_features.c from v20.7.0. The header file is called cpu_features.h (note underscore vs. dash) and that's what cpu_features.c includes.

@MatteoBax
Copy link
Contributor Author

MatteoBax commented Sep 21, 2023 •
edited
Loading

I redownloaded the Node.js (v20.7.0) source but it still gives me the same error.

On line 43 of cpu_features.c:
#include <cpu-features.h>

@bnoordhuis
Copy link
Member

Oh, I was looking at the wrong line. Problem with your SDK install, can't help you with that.

@MatteoBax
Copy link
Contributor Author

MatteoBax commented Sep 22, 2023 •
edited
Loading

I opened another issue because I can't resolve the problem.

nodejs-github-bot pushed a commit that referenced this issue Sep 23, 2023
@bnoordhuis
deps: remove pthread-fixes.c from uv.gyp
914ad2f 
The file was removed in the latest libuv upgrade. Remove it from the
build recipe as well.

Fixes: #49739
PR-URL: #49744
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
ruyadorno pushed a commit that referenced this issue Sep 28, 2023
@bnoordhuis @ruyadorno
deps: remove pthread-fixes.c from uv.gyp
b8a4fef 
The file was removed in the latest libuv upgrade. Remove it from the
build recipe as well.

Fixes: #49739
PR-URL: #49744
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@bnoordhuis @alexfernandez
deps: remove pthread-fixes.c from uv.gyp
66d5d35 
The file was removed in the latest libuv upgrade. Remove it from the
build recipe as well.

Fixes: nodejs#49739
PR-URL: nodejs#49744
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android Issues and PRs related to the android platform. build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: remove pthread-fixes.c from uv.gyp bnoordhuis/io.js
3 participants
@bnoordhuis @tniessen @MatteoBax