Skip to content

v18.x - test-dns-ipv6 fails in 18.17.0 and later #49203

Closed
Closed
v18.x - test-dns-ipv6 fails in 18.17.0 and later#49203
Labels
netIssues and PRs related to the net subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@mhdawson
mhdawson
opened on Aug 16, 2023

Version

v18.17.0

Platform

at least linux

Subsystem

net

What steps will reproduce the bug?

tools/test.py test/internet/test-dns-ipv6

How often does it reproduce? Is there a required condition?

100%

What is the expected behavior? Why is that the expected behavior?

Test passes

What do you see instead?

Test passes

midawson@drx-hemera io.js]$ tools/test.py test/internet/test-dns-ipv6
=== release test-dns-ipv6 ===                   
Path: internet/test-dns-ipv6
test_resolve6
test_reverse_ipv6
node:internal/errors:496
    ErrorCaptureStackTrace(err);
    ^

Error: getHostByAddr EINVAL 2001:4860:4860::8888
    at node:internal/dns/promises:280:14
    at new Promise (<anonymous>)
    at createResolverPromise (node:internal/dns/promises:267:10)
    at ResolverBase.getHostByAddr (node:internal/dns/promises:299:12)
    at test_reverse_ipv6 (/home/midawson/newpull/io.js/backports/io.js/test/internet/test-dns-ipv6.js:72:36)
    at next (/home/midawson/newpull/io.js/backports/io.js/test/internet/test-dns-ipv6.js:22:7)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  errno: -22,
  code: 'EINVAL',
  syscall: 'getHostByAddr',
  hostname: '2001:4860:4860::8888'
}

Additional information

No response

Activity

  1. mhdawson commented on Aug 16, 2023

    @mhdawson
    mhdawson
    on Aug 16, 2023
    MemberAuthor

    I did some bisection as part of #49183 which was what led me to open this issue.

  2. mhdawson commented on Aug 16, 2023

    @mhdawson
    mhdawson
    on Aug 16, 2023
    MemberAuthor

    Using git bisect it seems to indicate that it was this PR that causes the failure:

    0dc485eb28fb05eafad4dc78c646d917d8d4024a is the first bad commit
commit 0dc485eb28fb05eafad4dc78c646d917d8d4024a
Author: Yagiz Nizipli <yagiz@nizipli.com>
Date:   Fri Mar 31 09:04:03 2023 -0400

    url: drop ICU requirement for parsing hostnames
    
    PR-URL: https://github.com/nodejs/node/pull/47339
    Backport-PR-URL: https://github.com/nodejs/node/pull/48345
    Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>

 deps/ada/ada.gyp                     | 19 ++-----------------
 doc/api/url.md                       | 25 +++++++++++++++----------
 lib/internal/idna.js                 |  9 ++-------
 test/benchmark/test-benchmark-url.js | 14 +-------------
 test/wpt/status/url.json             | 21 ---------------------
 5 files changed, 20 insertions(+), 68 deletions(-)

  3. mhdawson commented on Aug 16, 2023

    @mhdawson
    mhdawson
    on Aug 16, 2023
    MemberAuthor

    @anonrig can you take a look at the backport and see if you can spot why it might be causing that test to fail?

  4. anonrig commented on Aug 16, 2023

    @anonrig
    anonrig
    on Aug 16, 2023
    Member

    We had a similar issue in the past: #48262. Might be related to it. I'll take a look at it soon.

    I think we should backport these 2 pull requests as well:

  5. anonrig commented on Aug 16, 2023

    @anonrig
    anonrig
    on Aug 16, 2023
    Member

    I think this is caused by calling domainToASCII instead of ada::idna::to_ascii.

    https://github.com/nodejs/node/blob/v18.x-staging/lib/internal/idna.js#L3

  6. mhdawson
    added a commit that references this issue on Aug 17, 2023

    build: expand when we run internet tests

    81de6ca

  7. anonrig commented on Aug 18, 2023

    @anonrig
    anonrig
    on Aug 18, 2023
    Member

    Does this issue persist with the v18 proposal?

  8. nodejs-github-bot
    added a commit that references this issue on Aug 19, 2023

    build: expand when we run internet tests

    5026293
  9. VoltrexKeyva
    added
    netIssues and PRs related to the net subsystem.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Aug 22, 2023
  10. UlisesGascon
    added a commit that references this issue on Sep 10, 2023

    build: expand when we run internet tests

    34a2590

  11. richardlau commented on Sep 19, 2023

    @richardlau
    richardlau
    on Sep 19, 2023
    Member

    This was fixed in Node.js 18.18.0.

  12. richardlau
    closed this as completedon Sep 19, 2023
  13. targos
    added a commit that references this issue on Nov 27, 2023

    build: expand when we run internet tests

    9e1c531
  14. sercher
    added 2 commits that reference this issue on Apr 25, 2024

    build: expand when we run internet tests

    aee579f

    build: expand when we run internet tests

    36dbbc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    netIssues and PRs related to the net subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions