Skip to content

Upgrade Ada 2.5.x to v18 #48343

Description

@hoikin

What is the problem this feature will solve?

Node 18.16 are have Ada 1.x version while 20 already using Ada 2.x. Version

What is the feature you are proposing to solve the problem?

Suspected some bug introduced by Ada since 18.16 caused a lot of Malloc error or double free error. The server will stop response and we need restart the server to accept request again

What alternatives have you considered?

Any workaround to turn off Ada parser in 18.x version

Activity

  1. self-assigned this
    on Jun 5, 2023
  2. moved this from Pending Triage to In Progress in Node.js feature requestson Jun 5, 2023
  3. anonrig commented on Jun 5, 2023

    @anonrig
    Member

    I'm opening a backport pull request.

  4. anonrig commented on Jun 5, 2023

    @anonrig
    Member

    Suspected some bug introduced by Ada since 18.16 caused a lot of Malloc error or double free error. The server will stop response and we need restart the server to accept request again

    Can you explain, and share a reproduction? What is the root cause of your suspicion?

  5. added
    whatwg-urlIssues and PRs related to the WHATWG URL implementation.
    on Jun 5, 2023
  6. moved this from In Progress to Done in Node.js feature requestson Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feature requestIssues requesting new Node.js features.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions