Repository navigation
Support snapshotting node:test #47832
Copy link
Copy link
Closed as not planned
Labels
feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.test_runnerIssues and PRs related to the test runner subsystem.Issues and PRs related to the test runner subsystem.
Description
Activity
cc @joyeecheung
We don't support udp and the test module in the snapshot yet.
- addedtest_runnerIssues and PRs related to the test runner subsystem.Issues and PRs related to the test runner subsystem.
on May 10, 2023 - addedfeature requestIssues requesting new Node.js features.Issues requesting new Node.js features.
on Aug 11, 2023 - changed the title
[-]`Unknown external reference` error when building a snapshot that requires the `test` module[/-][+]Support snapshotting node:test[/+]on Aug 11, 2023 There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
- addedstaleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
on Feb 8, 2024 github-actions commented
on Mar 10, 2024 on Mar 10, 2024 – with GitHub ActionsContributorMore actionsThere has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.
For more information on how the project manages feature requests, please consult the feature request management document.
Metadata
Metadata
Assignees
Labels
feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.test_runnerIssues and PRs related to the test runner subsystem.Issues and PRs related to the test runner subsystem.
Version
v20.0.0
Platform
No response
Subsystem
bootstrap
What steps will reproduce the bug?
So it complains that
UDPWrapBase::RecvStart()-node/src/udp_wrap.cc
Lines 645 to 648 in b0ca770
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
Should warn and exit with a 0 error code instead of crashing.
What do you see instead?
It crashes.
Additional information
After #47779 lands, the error would reproduce while building a snapshot that requires the
node:testmodule instead oftest.