Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/reporters can be required #47828

Closed
targos opened this issue May 3, 2023 · 1 comment · Fixed by #47831
Closed

test/reporters can be required #47828

targos opened this issue May 3, 2023 · 1 comment · Fixed by #47831
Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.

Comments

@targos
Copy link
Member

targos commented May 3, 2023 

$ node -p "require('test/reporters')"
{ dot: [Getter], spec: [Getter], tap: [Getter] }

I don't know if it's intended, but I find this confusing since the node: scheme is mandatory for require('node:test')

@nodejs/test_runner
@targos targos added the test_runner Issues and PRs related to the test runner subsystem. label May 3, 2023
@benjamingr benjamingr added the confirmed-bug Issues with confirmed bugs. label May 3, 2023
@MoLow MoLow mentioned this issue May 3, 2023
Merged
@ljharb
Copy link
Member

ljharb commented May 3, 2023

The confusing thing is that it's mandatory for test, imo.

nodejs-github-bot pushed a commit that referenced this issue May 5, 2023
@MoLow
module: block requiring test/reporters without scheme
d55b84b 
PR-URL: #47831
Fixes: #47828
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos pushed a commit that referenced this issue May 12, 2023
@MoLow @targos
module: block requiring test/reporters without scheme
739113f 
PR-URL: #47831
Fixes: #47828
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
danielleadams pushed a commit that referenced this issue Jul 6, 2023
@MoLow @danielleadams
module: block requiring test/reporters without scheme
8afdc5b 
PR-URL: #47831
Fixes: #47828
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
MoLow added a commit to MoLow/node that referenced this issue Jul 6, 2023
@MoLow
module: block requiring test/reporters without scheme
cf8845d 
PR-URL: nodejs#47831
Fixes: nodejs#47828
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

module: block requiring test/reporters without scheme MoLow/node
3 participants
@ljharb @benjamingr @targos