Repository navigation
SIGINT not triggering with readline #4758
Description
Activity
Hi @felipenmoura. Thanks for the report. Could you possibly give us a reduced test case with no external dependencies that shows this behavior so we can reproduce? Thanks!
@felipenmoura If you are trying to trigger by
ctrl+C, that won't work, because readline catches the keys?Reacted by electrovirYep.
That's what is happening.
It's being discussed in Inquirer.js, here: SBoudrias/Inquirer.js#293 (comment)
Inquirer uses realine internally, therefore, who uses it cannot catch the SIGINT!By the way, a test case:
process.on('SIGINT', function(){ console.log('oh, you triggered it!'); }); const readline = require('readline'); const rl = readline.createInterface({ input: process.stdin, output: process.stdout }); rl.question('What do you think of Node.js? ', (answer) => { console.log('Thank you for your valuable feedback, which was:\n', answer); rl.close(); });
Reacted by D.C. Rockwell and Gaurav SinghSo, readline is actually handles it, but only if it thinks it's input is a TTY: https://github.com/nodejs/node/blob/master/lib/readline.js#L693-L701
Adding the
SIGINTlistener on the readline instance itself instead ofprocessshould work?Reacted by D.C. Rockwell, Titouan Teyssier, Tom, Doug Day, Christian Tapia, Sergey Lubeckiy, Joakim L. Christiansen, electrovir, Eric Eastwood and RomThis looks to have been solved for some time now so I'll go ahead and close the issue. Holler if it should be reopened.
When using readline, the
process.on('SIGINT', ...)is never triggered.Is that planned, or perhaps a bug?
I searched and did not find other issues about it.