"MaxListenersExceededWarning: Possible EventTarget memory leak detected" from fetch with AbortSignal #46525

Activity

1. joshkel commented on Feb 6, 2023

   

   joshkel

   on Feb 6, 2023

   Last edited by joshkel

   ContributorAuthor

   More actions

   See nodejs/undici#939.

   If I use undici directly, I get the MaxListenersExceededWarning, but there does not appear to be a memory leak.

   If I use Node.js's built-in fetch (which I understand uses undici), I get the MaxListenersExceededWarning, and memory usage steadily increases.

   // Uncomment to compare implementations
   //const {fetch} = require('undici');
   
   async function main() {
     const controller = new AbortController();
     while (true) {
       try {
         await fetch('http://example.com', { signal: controller.signal });
       } catch (e) {
       }
     }
   }
   
   main();
2. KhafraDev commented on Feb 6, 2023

   

   KhafraDev

   on Feb 6, 2023

   Member

   More actions

   undici cleans up the listeners properly, the issue is that the signal is never being aborted and the gc won't run in the loop so the listeners aren't being removed instantly.
3. joshkel commented on Feb 6, 2023

   

   joshkel

   on Feb 6, 2023

   Last edited by joshkel

   ContributorAuthor

   More actions

   Thanks for the reply, @KhafraDev. I'm not sure that that's what's going on - or maybe I'm not understanding things:

   • Since the for loop uses await and has to wait for lots of HTTP requests, why wouldn't the GC run?

   • If I run the script indefinitely (see comment), then using Node's fetch causes an OOM after 70 minutes. This makes it look like the GC is running but isn't able to reclaim memory?

     [83018:0x118040000]  4300762 ms: Mark-sweep 3966.5 (4137.6) -> 3957.5 (4142.3) MB, 2935.9 / 1.9 ms  (average mu = 0.923, current mu = 0.716) task; scavenge might not succeed
     [83018:0x118040000]  4313057 ms: Mark-sweep 3973.0 (4143.8) -> 3964.0 (4148.8) MB, 4739.6 / 1.5 ms  (average mu = 0.846, current mu = 0.615) task; scavenge might not succeed
     
     
     <--- JS stacktrace --->
     
     FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory
     

   • If I run the script indefinitely using Undici directly, I still get the MaxListenersExceededWarning message, but memory usage appears fairly stable (100MB after 15 minutes), so it appears that Undici 5.16 behaves differently than Undici via Node.js's built-in fetch.
4. ronag

   closed this as completedin undici#1910on Feb 7, 2023