Skip to content

Replacing benchmark/compare.R with a JavaScript implementation #45390

Open
@joyeecheung

Description

@joyeecheung

Since I updated to macOS Monterey and R 4.2+ I am no longer able to install the packages required by compare.R. I recently found out about https://github.com/targos/node-benchmark-compare (h/t @targos) and gave it a try, it worked very well for me. I think in the past we had discussion about replacing this script with a JS implementation, it didn't end up fruitful because of the lack of implementation of the statistical distribution required by the script. Now that seems to be solved already by https://github.com/nearform/node-cephes (see #44974 (comment)). So I am wondering if it's time to reopen the discussion.

I think we can basically just vendor in the node-benchmark-compare package into tools/ or benchmark/ and replace the command cat results.csv | Rscript benchmark/compare.R with node-benchmark-compare results.csv (both the benchmark guide and the script used by the CI need to be updated, though in the case of the latter we might have to un-archive the repo, or edit the CI config to point to somewhere else?)

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to the benchmark subsystem.metaIssues and PRs related to the general management of the project.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions