Skip to content

Request to backport "fix memory leak when nghttp2 hd threshold is reached" into v14.x  #45295

Closed
@ywave620

Description

@ywave620

Version

14x

Platform

linux,mac,window

Subsystem

http2

What steps will reproduce the bug?

As shown in #35233
Fix in #41502

How often does it reproduce? Is there a required condition?

Consistent reproducable

What is the expected behavior?

no crash

What do you see instead?

./src/node_http2.cc:522:virtual node::http2::Http2Session::~Http2Session(): Assertion `(current_nghttp2_memory_) == (0)' failed.
1: 0xa02dd0 node::Abort() [node]

Additional information

I can't find the fix commit(f98a785) in https://github.com/nodejs/node/blob/v14.x/doc/changelogs/CHANGELOG_V14.md, since this is a critial bug that will lead to crash and v14.x is a LTS, I request Node team to backport it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions