windows build start failed on main caused by MSVC update

[gengjiawen]

** TLDR **
MSVC don't care about this issue. nothing to do on our side

**TLDR: Please upvote this MSVC issue to help us resolve this issue.**

https://developercommunity.visualstudio.com/t/build-failed-on-Nodejs-introduced-in-17/10201632

Details

works good:

https://github.com/nodejs/node/runs/6376797643?check_suite_focus=true
Visual Studio: 17.1.32421.90 (Visual Studio Enterprise 2022)

failed:
https://github.com/nodejs/node/runs/6428804600?check_suite_focus=true

Visual Studio: 17.2.32505.173 (Visual Studio Enterprise 2022)

I don't know it's a new bug or MSVC introduced a braking change.

cc @nodejs/build @nodejs/actions

also we have #42560 pending on MSVC side to fix.

[gengjiawen]

Looks like we need to do something similar https://sourcegraph.com/github.com/nodejs/node/-/blob/deps/v8/src/objects/fixed-array.h?L137 for get method.

[dennisameling]

The fix reported in #42560 fixes the VS2022 build for Node 14.x and 16.x (MS just released the fix for that in VS 2022 17.3), but the issue with the main branch remains:

  mksnapshot.cc
  snapshot-empty.cc
F:\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]
F:\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]
F:\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]
F:\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]
F:\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]
F:\node\deps\v8\src\base\bits.h(340,31): warning C4146: unary minus operator applied to unsigned type, result still unsigned [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]
     Creating library ..\..\out\Release\mksnapshot.lib and object ..\..\out\Release\mksnapshot.exp
mksnapshot.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]
platform-embedded-file-writer-aix.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [F:\node\tools\v8_gypfiles\mksna
pshot.vcxproj]
platform-embedded-file-writer-generic.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [F:\node\tools\v8_gypfiles\m
ksnapshot.vcxproj]
platform-embedded-file-writer-mac.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [F:\node\tools\v8_gypfiles\mksna
pshot.vcxproj]
platform-embedded-file-writer-win.obj : error LNK2001: unresolved external symbol "public: class v8::internal::Object __cdecl v8::internal::FixedArray::get(int)const " (?get@FixedArray@internal@v8@@QEBA?AVObject@23@H@Z) [F:\node\tools\v8_gypfiles\mksna
pshot.vcxproj]
..\..\out\Release\mksnapshot.exe : fatal error LNK1120: 1 unresolved externals [F:\node\tools\v8_gypfiles\mksnapshot.vcxproj]

As @gengjiawen already mentioned above, a similar fix is most likely needed for the FixedArray::get method. I'm happy to help adding a fix, but a total newbie to C++ so not sure which part in fixed-array.h to fix.

[gengjiawen]

As @gengjiawen #43092 (comment), a similar fix is most likely needed for the FixedArray::get method. I'm happy to help adding a fix, but a total newbie to C++ so not sure which part in fixed-array.h to fix.

I did more research, it's actually a MSVC optimize flag regression. The debug build works. But I have no clue which optimize flag cause this.