Buffer constructor not allocating at pool

[maximelkin]

Affected URL(s)

https://nodejs.org/dist/latest/docs/api/buffer.html#static-method-bufferallocunsafesize

Description of the problem

The Buffer module pre-allocates an internal Buffer instance of size Buffer.poolSize that is used as a pool for the fast allocation of new Buffer instances created using ...blah blah..., and the deprecated new Buffer(size) constructor ...blah blah..

This behaviour changed at 7eb1b46 (v8.0.0), new Buffer(size) will never use preallocated pool.

[jasnell]

Looks like just a documentation bug. Interested in opening a pull request? :-)

[maximelkin]

Wait, I'm not sure. This commit actually about zero-filling, new Buffer() can actually allocate at internal pool, excluding case when passing number as argument. So strings & arrays - still can be allocated at internal pool (with same restrictions about size).

Not sure how to formulate this clearly & understandable.