Skip to content

Node.js readline.question still prompts question after readline.closeΒ #42450

Closed
#42464
Closed
Node.js readline.question still prompts question after readline.close#42450
#42464
Labels
readlineIssues and PRs related to the built-in readline module.

Description

@qiulang
qiulang
opened on Mar 24, 2022

What is the problem this feature will solve?

When I close readline, readline.question still prompts the question, but the callback won't be called and the process hangs!

const readline = require('readline').createInterface({
    input: process.stdin,
    output: process.stdout
  })
  
  readline.question(`What's your name?`, name => {
    console.log(`Hi ${name}!`)
    readline.close()
    readline.question(`How are you?`, how => {
      console.log(`Good to know you are ${how}!`)
      //readline.close() should close here
    })
  })

What is the feature you are proposing to solve the problem?

If readline.close() I think it is better readline.question not prompt, so no hang either.

What alternatives have you considered?

No response

Activity

  1. qiulang
    added
    feature requestIssues requesting new Node.js features.
    on Mar 24, 2022
  2. qiulang
    changed the title [-]Node.js readline.question still prompts question when readline.close[/-] [+]Node.js readline.question still prompts question after readline.close[/+] on Mar 24, 2022
  3. Mesteery
    added
    readlineIssues and PRs related to the built-in readline module.
    feature requestIssues requesting new Node.js features.
    and removed
    feature requestIssues requesting new Node.js features.
    on Mar 24, 2022

  4. Trott commented on Mar 24, 2022

    @Trott
    Trott
    on Mar 24, 2022
    Member

    @nodejs/readline

  5. targos
    removed
    feature requestIssues requesting new Node.js features.
    on Apr 4, 2022
  6. nodejs-github-bot
    closed this as completedin #42464on Apr 8, 2022
  7. nodejs-github-bot
    added a commit that references this issue on Apr 8, 2022

    readline: fix question still called after closed

    d36b60e
  8. xtx1130
    added a commit that references this issue on Apr 25, 2022

    readline: fix question still called after closed

    4f3823e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    readlineIssues and PRs related to the built-in readline module.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions