Repository navigation
Nominating Akhil Marsonya (marsonya) to be a collaborator #41781
Description
Activity
Thank you!! It's an Honour 😊
Reacted by Alexander KupchenkoWhat is the problem this feature will solve?
Lack of marsonya in collaborator team
I can reproduce on
masterand all the active release lines, we should definitely fix this!Jokes aside, it's a warm +1 from me 🤗
Reacted by Gireesh Punathil, akhil marsonya, Benjamin Gruenbaum, Mesteery, Voltrex, Qingyu Deng and Darshan Sen+1 from me
Hey, not a block but I would like to see demonstrated competence in the codebase to be able to trust them with landing stuff. Stuff like #41815 is a bit worrying to me to be completely honest <3
Hey, not a block but I would like to see demonstrated competence in the codebase to be able to trust them with landing stuff. Stuff like #41815 is a bit worrying to me to be completely honest <3
I'm OK with people freely admitting when they don't know something and asking. I prefer that to people not asking or pretending they know more than they do. Concerns for me would be signs that someone is not aware of the limits of their knowledge and/or does not act with appropriate caution on things they don't fully understand. (I'm not seeing those problems here.)
Reacted by Gireesh Punathil and Antoine du HamelTo be clear the issue I have isn't with not-knowing (I don't know most of the code). It's about collaboratorship implying someone's self-sufficiency in the codebase and the capability to look these things up.
Looking at his many helpful commits, the help and the other interactions - I see a tremendous amount of helpfulness and willingness to help the project. What I'm missing is demonstrated competence in the Node.js core codebase itself.
That said - I acknowledge the meaning of collaborator may have shifted a bit or that other people might have a different impression and I haven't had a single negative interaction (and did have several good ones) with Akhil. So to be clear I am not blocking this nomination and I believe that if there are multiple 👍 s from the TSC it's totally fine for it to go through.
for what it's worth after this comment I am satisfied with @marsonya 's ability in the code. Which again I wasn't blocking on in the first place so mostly theoretical stuff :)
this nomination has passed; I will connect with Akhil to schedule the onboarding.
Reacted by Rich Trott- added a commit that references this issue
on Feb 15, 2022 - added 2 commits that reference this issue
on Apr 21, 2022
What is the problem this feature will solve?
Lack of marsonya in collaborator team
What is the feature you are proposing to solve the problem?
marsonya in collaborator team
What alternatives have you considered?
marsonya continue to be a triager - which potentially ignores the acknowledgement they deserve.
I would like to nominate Akhil Marsonya (marsonya) to be a collaborator. Akhil is a member of the triage team, and has made effective use of the role to make inroads into the codebase as well as helping Node.js users. Below is the summary of their contributions:
Pull requests and issues opened throughout the Node.js organization: https://github.com/search?q=author:marsonya+org:nodejs
Commits in nodejs/node: https://github.com/nodejs/node/commits?author=marsonya
Pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=author:marsonya
Comments on pull requests and issues in nodejs/node: https://github.com/nodejs/node/issues?q=commenter:marsonya
Reviews on pull requests in nodejs/node: https://github.com/nodejs/node/pulls?q=reviewed-by:marsonya
Help provided to end-users and novice contributors: https://github.com/nodejs/help/issues?q=commenter:marsonya