`make lint-js` throws error

[MrJithil]

Version

v18.0.0-pre

Platform

Linux 5.10.16.3-microsoft-standard-WSL2 #1 SMP Fri Apr 2 22:23:49 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

tools

What steps will reproduce the bug?

run make lint-js and observe the errors in WSL Ubuntu. I have tried the latest source on macOS and faced the same.

/mnt/e/OpenSource/node$ make lint-js
Running JS linter...

Oops! Something went wrong! :(

ESLint: 8.8.0

/mnt/e/OpenSource/node/tools/node_modules/eslint/node_modules/eslint:1
(function (exports, require, module, __filename, __dirname) { ..
                                                              ^

SyntaxError: Unexpected token '.'
    at new Script (node:vm:100:7)
    at NativeCompileCache._moduleCompile (/mnt/e/OpenSource/node/tools/node_modules/eslint/node_modules/v8-compile-cache/v8-compile-cache.js:240:18)
    at Module._compile (/mnt/e/OpenSource/node/tools/node_modules/eslint/node_modules/v8-compile-cache/v8-compile-cache.js:184:36)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (/mnt/e/OpenSource/node/tools/node_modules/eslint/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/mnt/e/OpenSource/node/tools/node_modules/eslint/node_modules/eslint-plugin-jsdoc/dist/rules/checkExamples.js:8:15)
    at Module._compile (/mnt/e/OpenSource/node/tools/node_modules/eslint/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
make: *** [Makefile:1352: lint-js] Error 2

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Linters should run successfully.

What do you see instead?

Errors and linting broken

Additional information

No response

[Trott]

If you haven't compiled Node.js locally, make lint-js will use the version of node in your path. So I'm guessing you have Node.js 10.x or older installed. Node.js 10.x is unsupported and will result in this error.

To fix the issue, you can either build Node.js locally (no need to install it--just having it built in the your project directory will be enough) or update your system Node.js to 12.x or newer.

[MrJithil]

I'm using the locally built version v18.0.0-pre and the installed version is v16.13.2

[Trott]

@MrJithil OK, that's surprising. What happens if you run tools/node_modules/eslint/bin/eslint.js from the command line?

[Trott]

@MrJithil OK, that's surprising. What happens if you run tools/node_modules/eslint/bin/eslint.js from the command line?

In particular, since you have the 18.0.0-pre compiled, do all three of these work?

$ tools/node_modules/eslint/bin/eslint.js
$ node tools/node_modules/eslint/bin/eslint.js
$ ./node tools/node_modules/eslint/bin/eslint.js
$ 

[MrJithil]

Except for the first one, the rest of them are executing well.

But, it's not a throwing error while manually creating a lint error in a file.

[benjamingr]

Hmm, that's odd since it takes node from the environment so if node tools/node_modules/eslint/bin/eslint.js passes then tools/node_modules/eslint/bin/eslint.js should too.

It might be a WSL related issue? (though why would it?) there is probably something else at play based on the environment.

[Trott]

Seems like the problem is happening in call available-node in the Makefile. Let's confirm that.

Does make tools/doc/node_modules fail in a similar way? Or does that succeed?

[MrJithil]

Seems return success.

[Trott]

Seems return success.

The way make works, that didn't run anything because the target is already built. Do this to cause make to try to run the recipe:

touch tools/doc/package.json && make tools/doc/node_modules

If that fails, at least we have a narrow area to find the cause of the problem. If that succeeds, the search continues....

[MrJithil]

touch: setting times of 'tools/doc/package.json': Invalid argument

Got this error

[Trott]

touch: setting times of 'tools/doc/package.json': Invalid argument

Got this error

OK, instead of using touch, how about remove tools/doc/node_modules and then run make tools/doc/node_modules?

[MrJithil]

Sorry. I ran the previous command in the wrong shell. Now, I corrected it and ran touch tools/doc/package.json && make tools/doc/node_modules again.

Waiting for the results.

Seems like its taking time.

[MrJithil]

Here is the error for touch tools/doc/package.json && make tools/doc/node_modules

Trying now with remove tools/doc/node_modules and then run make tools/doc/node_modules

[MrJithil]

And below is the output @Trott