Repository navigation
v0.10 and v0.12 node-v0.x.y-headers.tar.gz file is too big #4140
Description
Activity
/cc @nodejs/build
Looking at https://nodejs.org/download/release/v0.12.8/node-v0.12.8-headers.tar.gz the majority of the file size is the inclusion of bin/node and npm (lib/node_modules/npm) both of which I wouldn't expect to see in this file.
@rvagg https://github.com/nodejs/node/blob/v0.12/Makefile#L422 calls
HEADERS_ONLY=1 $(PYTHON) tools/install.py install '$(TARNAME)' '/'
but https://github.com/nodejs/node/blob/v0.12/tools/install.py doesn't check HEADERS_ONLY -- Looks like thetools/install.pychanges from 628a3ab would need to be backported?That sounds right @richardlau! I didn't patch install.py in my round of backports so that would explain it. Do you care to do up a PR for this?
@rvagg Sure, I'll put together a PR. Do we want two separate PRs (one for v0.10 and one for v0.12)? Or can we make do with one and pick the change across?
@richardlau if the change is identical then just one PR to
v0.12-stagingand if you can label it put "lts-watch-v0.10" and one of us will try and watch for it.Was landed in #4149 to relevant branches without a "Fixes:". Closing.
Need to take a look at the headers tasks in
Makefileand figure out why they are in the 5-7Mb range rather than 500kb. If we get this sorted out and make sure they are correct we may be able to hard-wire in some rules to node-gyp to fetch that file for certain semver ranges of v0.10.x and v0.12.x (probably won't be doing aprocess.releasefor these old versions).