Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non readable Duplex should not be readableAborted #40800

Closed
ronag opened this issue Nov 13, 2021 · 0 comments
Closed

non readable Duplex should not be readableAborted #40800

ronag opened this issue Nov 13, 2021 · 0 comments
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented Nov 13, 2021 

const x = new stream.Duplex({ readable: false, _write () {} })
x.destroy()
assert(!x.readableAborted)

We are missing a check in readableAborted getter regarding whether the Duplex is readable at all.
@ronag ronag added stream Issues and PRs related to the stream subsystem. good first issue Issues that are suitable for first-time contributors. labels Nov 13, 2021
@ronag ronag mentioned this issue Nov 13, 2021
Closed
@ronag ronag closed this as completed in 640bfb8 Nov 15, 2021
targos pushed a commit that referenced this issue Nov 21, 2021
@ronag @targos
stream: fix non readable Duplex readableAborted
7d127d2 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 30, 2022
@ronag @danielleadams
stream: fix non readable Duplex readableAborted
218ada9 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
@ronag @danielleadams
stream: fix non readable Duplex readableAborted
55c9349 
PR-URL: #40801
Fixes: #40800
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: fix non readable Duplex readableAborted nxtedition/node
1 participant
@ronag