-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-cluster-net-send failure on windows #3957
Comments
Fishrock123
added
windows
Issues and PRs related to the Windows platform.
test
Issues and PRs related to the tests.
labels
Nov 21, 2015
Trott
added a commit
to Trott/io.js
that referenced
this issue
Nov 24, 2015
See nodejs#3957 for details and examples failures. Ref: nodejs#3957
Trott
added a commit
to Trott/io.js
that referenced
this issue
Nov 25, 2015
See nodejs#3957 for details and examples failures. Ref: nodejs#3957 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: nodejs#4006
mscdex
added a commit
to mscdex/io.js
that referenced
this issue
Dec 29, 2015
Before this commit, it was possible on Windows for the server's 'connection' handler to be called *after* the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation. This commit waits until both handlers have been called before sending the handle to the master process. Fixes: nodejs#3957 PR-URL: nodejs#4444
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this issue
Jan 6, 2016
Before this commit, it was possible on Windows for the server's 'connection' handler to be called *after* the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation. This commit waits until both handlers have been called before sending the handle to the master process. Fixes: nodejs#3957 PR-URL: nodejs#4444 Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Jan 28, 2016
Before this commit, it was possible on Windows for the server's 'connection' handler to be called *after* the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation. This commit waits until both handlers have been called before sending the handle to the master process. Fixes: #3957 PR-URL: #4444 Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Feb 11, 2016
Before this commit, it was possible on Windows for the server's 'connection' handler to be called *after* the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation. This commit waits until both handlers have been called before sending the handle to the master process. Fixes: #3957 PR-URL: #4444 Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this issue
Feb 11, 2016
Before this commit, it was possible on Windows for the server's 'connection' handler to be called *after* the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation. This commit waits until both handlers have been called before sending the handle to the master process. Fixes: nodejs#3957 PR-URL: nodejs#4444 Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this issue
Feb 15, 2016
Before this commit, it was possible on Windows for the server's 'connection' handler to be called *after* the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation. This commit waits until both handlers have been called before sending the handle to the master process. Fixes: nodejs#3957 PR-URL: nodejs#4444 Reviewed-By: Rich Trott <rtrott@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this issue
Apr 2, 2016
See nodejs#3957 for details and examples failures. Ref: nodejs#3957 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: nodejs#4006
scovetta
pushed a commit
to scovetta/node
that referenced
this issue
Apr 2, 2016
Before this commit, it was possible on Windows for the server's 'connection' handler to be called *after* the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation. This commit waits until both handlers have been called before sending the handle to the master process. Fixes: nodejs#3957 PR-URL: nodejs#4444 Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://ci.nodejs.org/job/node-test-binary-windows/91/RUN_SUBSET=3,VS_VERSION=vs2015,label=win2012r2/tapTestReport/test.tap-25/
(Failed against #3954, unrelated.)
The text was updated successfully, but these errors were encountered: