Skip to content

Unable to make doc-only #38938

Description

@mcollina
  • Version: master
  • Platform: linux
  • Subsystem: doc

What steps will reproduce the bug?

make doc-only

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

docs are build

What do you see instead?

if [ -x /home/matteo/repositories/node/./node ] && [ -e /home/matteo/repositories/node/./node ]; then /home/matteo/repositories/node/./node  tools/doc/generate.js --node-version=v17.0.0 --apilinks=out/doc/apilinks.json doc/api/debugger.md --output-directory=out/doc/api --versions-file=out/previous-doc-versions.json; elif [ -x `command -v node` ] && [ -e `command -v node` ] && [ `command -v node` ]; then `command -v node`  tools/doc/generate.js --node-version=v17.0.0 --apilinks=out/doc/apilinks.json doc/api/debugger.md --output-directory=out/doc/api --versions-file=out/previous-doc-versions.json; else echo "No available node, cannot run \"node  tools/doc/generate.js --node-version=v17.0.0 --apilinks=out/doc/apilinks.json doc/api/debugger.md --output-directory=out/doc/api --versions-file=out/previous-doc-versions.json\""; exit 1; fi;
/home/matteo/repositories/node/tools/doc/node_modules/unified/index.js:469
    throw new Error(
    ^

Error: `processSync` finished async. Use `process` instead
    at assertDone (/home/matteo/repositories/node/tools/doc/node_modules/unified/index.js:469:11)
    at Function.processSync (/home/matteo/repositories/node/tools/doc/node_modules/unified/index.js:401:5)
    at Object.<anonymous> (/home/matteo/repositories/node/tools/doc/html.js:64:4)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Module.require (node:internal/modules/cjs/loader:1013:19)
    at require (node:internal/modules/cjs/helpers:93:18)
    at Object.<anonymous> (/home/matteo/repositories/node/tools/doc/generate.js:35:14)
make[1]: *** [Makefile:745: out/doc/api/debugger.html] Error 1
make: *** [Makefile:698: doc-only] Error 2

Additional information

There is likely some old cruft in my checkout that I can't seem to clean up make clean; make distclean don't do the trick.

Activity

  1. Trott commented on Jun 5, 2021

    @Trott
    Member

    I can try to take a look at this later, but my immediate thought is: Does rm -rf tools/doc/node_modules fix it?

  2. mcollina commented on Jun 5, 2021

    @mcollina
    SponsorMemberAuthor

    That did not work :/. For some reason I can't comprehend

    .processSync(gtocMD).toString();
    would like to be async.

  3. Trott commented on Jun 5, 2021

    @Trott
    Member

    That means that gtocMD() is supposed to be

    That did not work :/. For some reason I can't comprehend

    .processSync(gtocMD).toString();

    would like to be async.

    Yeah, that is odd. Is your git HEAD 78af363 or something else? Does it start working if you first run rm -rf out/doc/api/debugger.* or even rm -rf out/doc?

  4. mcollina commented on Jun 6, 2021

    @mcollina
    SponsorMemberAuthor

    Yes, I'm at 78af363

  5. Trott commented on Jun 6, 2021

    @Trott
    Member

    Maybe something weird in out/doc/api/debugger.md? Remove out/doc and try again? Or did you do that already?

  6. mcollina commented on Jun 6, 2021

    @mcollina
    SponsorMemberAuthor

    I removed everything several times. Maybe there is some residual in a gitignored dot-folder?

  7. targos commented on Jun 6, 2021

    @targos
    Member

    Last resort: git clean -fdx will remove everything that's either not tracked or gitignored

  8. mcollina commented on Jun 8, 2021

    @mcollina
    SponsorMemberAuthor

    Unfortunately even that or creating a fresh clone did not do the trick.

    I also tried looking at the various steps and I can't seem to find where that becomes async.

  9. targos commented on Jun 8, 2021

    @targos
    Member

    @mcollina can you try with #38966 ?

  10. mcollina commented on Jun 8, 2021

    @mcollina
    SponsorMemberAuthor

    @mcollina can you try with #38966 ?

    That does the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions