Skip to content

Revisiting: fix for loading module twice with different case on case insensitive FSes #38752

Closed
@jedwards1211

Description

@jedwards1211

@isaacs said in #5702 that it's impossible to tell if two filenames with different case point to the same file or not.

However, on mac OS at least with a case-insensitive filesystem, fs.stat will give the same ino for the same filename with different case. So it's completely possible, unless ino is somehow unreliable on some OSes.

I just ran into this issue due to a typo and it was mega confusing and annoying. Maybe ino was unavailable in the 0.x days, but it seems like there's no reason not to fix this now.

Seems to me that ino should be the real cache key, and require.cache should actually be retrofitted to proxy to an underlying ino-keyed cache. (I assume this would avoid duplicate loading multiple hardlinks to the same file as well). delete require.cache[key] would only actually delete the module if key is the last remaining path for the underlying ino.

However, I do read that inodes on windows are...complicated...so someone feel free to shoot holes in this proposal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    moduleIssues and PRs related to the module subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions