Hash.prototype._flush does not set state[kFinalized]

[misos1]

• Version: v16.1.0
• Platform: Darwin Kernel Version 20.4.0
• Subsystem: crypto

What steps will reproduce the bug?

https://github.com/nodejs/node/blob/master/lib/internal/crypto/hash.js#L90-L93

When using the stream interface of hash it will call this[kHandle].digest() in Hash.prototype._flush. After that it is possible to call Hash.prototype.digest which will call this[kHandle].digest() again. If that is ok then why is Hash.prototype.digest made in a way that it is not possible to call it more than once?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

[tniessen]

I believe this is to enable piping into a Hash object but still being able to call digest() to obtain the hash value instead of reading from the Hash object using the stream API, whereas calling digest() multiple times is usually unnecessary and might indicate a bug.

Possibly related: #28251

I am going to close this since there has been no activity in quite a while and I don't think this is really a bug, but please do feel free to reopen or comment if you think this warrants more discussion! :)