tlsServer.setTicketKeys results in an abort

[zyscoder]

• Version: v16.0.0-pre
• Platform: Linux 5.8.0-38-generic The binary and long term compatibility with node #43~20.04.1-Ubuntu SMP Tue Jan 12 16:39:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
• Subsystem: tlsServer.setTicketKeys

What steps will reproduce the bug?

Setup a node instance,

» node

and run the following javascript code.

tls = require('tls');tlsServer = new tls.Server();
tlsServer.setTicketKeys(1);

Then the node instance occurs an abort.

How often does it reproduce? Is there a required condition?

This abort can always be triggered following the steps above.

What is the expected behavior?

If any error occurs, an exception or other similar error-reporting stuff should be thrown. There is no reason to abort the whole node process.

What do you see instead?

» node
Welcome to Node.js v16.0.0-pre.
Type ".help" for more information.
> tls = require('tls');tlsServer = new tls.Server();
Server {
...
}
> tlsServer.setTicketKeys(1);
/home/zys/Toolchains/node/node[24181]: ../src/crypto/crypto_context.cc:1059:static void node::crypto::SecureContext::SetTicketKeys(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[0]->IsArrayBufferView()' failed.
 1: 0x56281bfeaaf4 node::Abort() [/home/zys/Toolchains/node/node]
 2: 0x56281bfeab88  [/home/zys/Toolchains/node/node]
 3: 0x56281c15a1ec node::crypto::SecureContext::SetTicketKeys(v8::FunctionCallbackInfo<v8::Value> const&) [/home/zys/Toolchains/node/node]
 4: 0x56281c269167 v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo) [/home/zys/Toolchains/node/node]
 5: 0x56281c269f10  [/home/zys/Toolchains/node/node]
 6: 0x56281c26a507  [/home/zys/Toolchains/node/node]
 7: 0x56281c26a79a v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/home/zys/Toolchains/node/node]
 8: 0x56281cc08259  [/home/zys/Toolchains/node/node]
[1]    24181 abort (core dumped)  /home/zys/Toolchains/node/node                                                                                                                                                                                               

Additional information

[Ayase-252]

reproducible in master branch

[Ayase-252]

Code in question is here. It may need more user-friendly argument type checking (e.g. throw an type error to JS)

node/src/crypto/crypto_context.cc

Line 1053 in 6c9b19a

void SecureContext::SetTicketKeys(const FunctionCallbackInfo<Value>& args) {

[EladKeyshawn]

Code in question is here. It may need more user-friendly argument type checking (e.g. throw an type error to JS)

node/src/crypto/crypto_context.cc

Line 1053 in 6c9b19a

void SecureContext::SetTicketKeys(const FunctionCallbackInfo<Value>& args) {

@Ayase-252 sounds reasonable I'm going to work on this alright ?