Skip to content

Improve windows build by pch #37098

Closed
Closed
@gengjiawen

Description

@gengjiawen

This patch bnoordhuis/v8-cmake#43 bring v8 build from 72min to 13min for v8.

I think apply this on our side will make us less suffer dealing with v8 on windows.

Not sure our https://github.com/nodejs/node/blob/master/tools/msvs/pch/v8_pch.h is enabled by default. But our surely take much more time, maybe can fix by add more headers ?

cc @nodejs/v8 @nodejs/platform-windows

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions