Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky sequential/test-fs-watch #36247

Closed
Trott opened this issue Nov 24, 2020 · 3 comments · Fixed by #36249
Closed

investigate flaky sequential/test-fs-watch #36247

Trott opened this issue Nov 24, 2020 · 3 comments · Fixed by #36249
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX.

Comments

@Trott
Copy link
Member

Trott commented Nov 24, 2020

  • Test: sequential/test-fs-watch
  • Platform: osx1015
  • Console Output:
01:28:10 not ok 3107 sequential/test-fs-watch
01:28:10   ---
01:28:10   duration_ms: 120.86
01:28:10   severity: fail
01:28:10   exitcode: -15
01:28:10   stack: |-
01:28:10     timeout
01:28:10   ...

test-orka-macos10.15-x64-2
@Trott Trott added fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Nov 24, 2020
@Trott
Copy link
Member Author

Trott commented Nov 24, 2020

Stress test: https://ci.nodejs.org/job/node-stress-single-test/205/

@Trott
Copy link
Member Author

Trott commented Nov 24, 2020

I'm pretty sure this is the old "macos returns the watcher before it's actually watching the file system" issue. My solution in the past has been to have the file modified every few seconds in the test instead of just once.

@Trott Trott mentioned this issue Nov 24, 2020
Merged
3 tasks
@Trott
Copy link
Member Author

Trott commented Nov 24, 2020

Stress test: https://ci.nodejs.org/job/node-stress-single-test/205/

Failed 2 times in 1000 runs on osx15. I'm able to replicate this locally. It failed 4 times in 1000 runs.

@Trott Trott closed this as completed in 8ba65b5 Nov 27, 2020
danielleadams pushed a commit that referenced this issue Dec 7, 2020
@Trott @danielleadams
test: fix flaky sequential/test-fs-watch
2c7358e 
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this issue May 1, 2021
@Trott @targos
test: fix flaky sequential/test-fs-watch
b11e3ea 
Fixes: #36247

PR-URL: #36249
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky sequential/test-fs-watch Trott/io.js
1 participant
@Trott