Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fails on master #35621

Closed
Flarna opened this issue Oct 12, 2020 · 0 comments
Closed

CI fails on master #35621

Flarna opened this issue Oct 12, 2020 · 0 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@Flarna
Copy link
Member

Flarna commented Oct 12, 2020 •
edited
Loading

  • Version: master
  • Platform: Windows
  • Subsystem: url

What steps will reproduce the bug?

run CI

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

CI pass

What do you see instead?

CI fail, see e.g.
https://ci.nodejs.org/job/node-test-binary-windows-native-suites/5470/#showFailuresLink
https://ci.nodejs.org/job/node-test-binary-windows-js-suites/6158/#showFailuresLink

Additional information

Seems this is caused by #35477

fyi @watilde
@Flarna Flarna added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Oct 12, 2020
@watilde watilde mentioned this issue Oct 13, 2020
Closed
3 tasks
nodejs-github-bot pushed a commit that referenced this issue Oct 13, 2020
@watilde @nodejs-github-bot
bootstrap: use file URL instead of relative url
8a12e99 
PR-URL: #35622
Fixes: #35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
joesepi pushed a commit to joesepi/node that referenced this issue Jan 8, 2021
@watilde @joesepi
test: update url test for win
8ce9cb8 
PR-URL: nodejs#35622
Fixes: nodejs#35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
joesepi pushed a commit to joesepi/node that referenced this issue Jan 8, 2021
@watilde @joesepi
bootstrap: use file URL instead of relative url
d0eef8d 
PR-URL: nodejs#35622
Fixes: nodejs#35621
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: update url test for win watilde/node
1 participant
@Flarna