Skip to content

policy tests fail if there is a package.json in parent directories #35600

Closed
Closed
policy tests fail if there is a package.json in parent directories#35600
Labels
policyHistorical issues and PRs related to the removed policy-manifest feature.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@jasnell
jasnell
opened on Oct 11, 2020

Just opening this so it's not forgotten.... Policy tests can fail if there is a package.json in the parent path of the local node.js repo

Error [ERR_MANIFEST_ASSERT_INTEGRITY]: The content of "file:///home/james/package.json" does not match the expected integrity. The resource was not found in the policy.
    at new NodeError (node:internal/errors:258:15)
    at Manifest.assertIntegrity (node:internal/policy/manifest:532:19)
    at Object.read (node:internal/modules/package_json_reader:34:16)
    at readPackage (node:internal/modules/cjs/loader:259:36)
    at readPackageScope (node:internal/modules/cjs/loader:292:19)
    at shouldUseESMLoader (node:internal/modules/run_main:36:15)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:67:24)
    at node:internal/main/run_main_module:17:47 {
  code: 'ERR_MANIFEST_ASSERT_INTEGRITY'
}

    at Object.<anonymous> (/home/james/node/node/test/parallel/test-policy-integrity-flag.js:64:10)
    at Module._compile (node:internal/modules/cjs/loader:1072:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1101:10)
    at Module.load (node:internal/modules/cjs/loader:937:32)
    at Function.Module._load (node:internal/modules/cjs/loader:778:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:72:12)
    at node:internal/main/run_main_module:17:47 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}
Command: out/Release/node /home/james/node/node/test/parallel/test-policy-integrity-flag.js

What steps will reproduce the bug?

How often does it reproduce? Is there a required condition?

What is the expected behavior?

What do you see instead?

Additional information

Activity

  1. bmeck commented on Oct 12, 2020

    @bmeck
    bmeck
    on Oct 12, 2020
    Member

    @jasnell this is intentional since that is how policies work, the CJS/ESM loaders crawl up to find "type" from package.json files and if it finds one that isn't allowed it fails. Is there some issue that needs to be fixed?

  2. jasnell commented on Oct 12, 2020

    @jasnell
    jasnell
    on Oct 12, 2020
    MemberAuthor

    Yes, I get that, it's just unexpected for the test suite to fail due to some factor completely outside of the project repo. Ideally there would be a way of sandboxing it or limiting the search path... or, if that's not possible, to provide a better error that describes why it's failing.

  3. bmeck commented on Oct 12, 2020

    @bmeck
    bmeck
    on Oct 12, 2020
    Member

    we could also just put a well known package.json in the test directory

  4. targos commented on Oct 13, 2020

    @targos
    targos
    on Oct 13, 2020
    Member

    we could also just put a well known package.json in the test directory

    Good idea. I'm on it.

  5. targos commented on Oct 13, 2020

    @targos
    targos
    on Oct 13, 2020
    Member

    Actually, I don't understand what needs to be changed to make it work, feel free to pick it up 😄 .

  6. watilde
    added
    policyHistorical issues and PRs related to the removed policy-manifest feature.
    testIssues and PRs related to Node.js core tests and test infrastructure.
    on Oct 16, 2020
  7. aduh95
    closed this as completedin 5b95f01on Nov 9, 2020
  8. danielleadams
    added a commit that references this issue on Nov 9, 2020

    test: improve error message for policy failures

    f73b8d8
  9. BethGriggs
    added 4 commits that reference this issue on Dec 9, 2020

    test: improve error message for policy failures

    c526d09

    test: improve error message for policy failures

    c05f85e

    test: improve error message for policy failures

    002005f
  10. Trott
    added a commit that references this issue on Apr 23, 2021

    test: add ancestor package.json checks for tmpdir

    f9e07e4
  11. targos
    added a commit that references this issue on Apr 29, 2021

    test: add ancestor package.json checks for tmpdir

    27d7588
  12. targos
    added 3 commits that reference this issue on May 30, 2021

    test: add ancestor package.json checks for tmpdir

    334558f

    test: add ancestor package.json checks for tmpdir

    6bd87ab

    test: add ancestor package.json checks for tmpdir

    a9ff9c0
  13. MayaLekova
    added a commit that references this issue on May 22, 2026

    test: improve error message for policy failures

    5b95f01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    policyHistorical issues and PRs related to the removed policy-manifest feature.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions