Skip to content

[v10.x] V8 builds are broken #35504

Closed
Closed
@richardlau

Description

@richardlau
  • Version: v10.x
  • Platform: Linux ppcle & s390x
  • Subsystem: V8/build

What steps will reproduce the bug?

The V8 CI (https://ci.nodejs.org/job/node-test-commit-v8-linux/) is currently broken on v10.x (see #35393 (comment)).

How often does it reproduce? Is there a required condition?

All the time.

What is the expected behavior?

V8 CI should pass.

What do you see instead?

V8 CI consistently fails on all three platforms.

11:04:17 + python tools/test.py -j 88 -p tap --mode=release --flaky-tests=run v8-updates
11:04:17 TAP version 13
11:04:17 1..2
11:04:18 ok 1 v8-updates/test-postmortem-metadata
11:04:18   ---
11:04:18   duration_ms: 0.713
11:04:18   ...
11:04:21 not ok 2 v8-updates/test-linux-perf
11:04:21   ---
11:04:21   duration_ms: 3.916
11:04:21   severity: fail
11:04:21   exitcode: 1
11:04:21   stack: |-
11:04:21     assert.js:339
11:04:21         throw err;
11:04:21         ^
11:04:21     
11:04:21     AssertionError [ERR_ASSERTION]: Couldn't find interpreted functionOne()
11:04:21         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark-ubuntu1604-intel-64/v8test/v8test/test/v8-updates/test-linux-perf.js:74:8)
11:04:21         at Module._compile (internal/modules/cjs/loader.js:778:30)
11:04:21         at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
11:04:21         at Module.load (internal/modules/cjs/loader.js:653:32)
11:04:21         at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
11:04:21         at Function.Module._load (internal/modules/cjs/loader.js:585:3)
11:04:21         at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
11:04:21         at startup (internal/bootstrap/node.js:283:19)
11:04:21         at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)
11:04:21   ...
  • Compilation failures on ppcle and s390x. cc @nodejs/platform-ppc @nodejs/platform-s390.
10:32:35 ../../src/heap/mark-compact.cc: In instantiation of ‘struct v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MinorNonAtomicMarkingState; v8::internal::Address = long unsigned int]::<lambda(class v8::internal::MaybeObject**)>’:
10:32:35 ../../src/heap/mark-compact.cc:2861:58:   required from ‘v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MinorNonAtomicMarkingState; v8::internal::Address = long unsigned int]’
10:32:35 ../../src/heap/mark-compact.cc:2860:20:   required from ‘struct v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers() [with MarkingState = v8::internal::MinorNonAtomicMarkingState]::<lambda(enum v8::internal::SlotType, v8::internal::Address, v8::internal::Address)>’
10:32:35 ../../src/heap/mark-compact.cc:2859:46:   required from ‘void v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers() [with MarkingState = v8::internal::MinorNonAtomicMarkingState]’
10:32:35 ../../src/heap/mark-compact.cc:2770:24:   required from ‘void v8::internal::RememberedSetUpdatingItem<MarkingState>::Process() [with MarkingState = v8::internal::MinorNonAtomicMarkingState]’
10:32:35 ../../src/heap/mark-compact.cc:4315:1:   required from here
10:32:35 ../../src/heap/mark-compact.cc:2862:39: error: ‘v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MinorNonAtomicMarkingState; v8::internal::Address = long unsigned int]::<lambda(v8::internal::MaybeObject**)>’ declared with greater visibility than the type of its field ‘v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MinorNonAtomicMarkingState; v8::internal::Address = long unsigned int]::<lambda(v8::internal::MaybeObject**)>::<this capture>’ [-Werror=attributes]
10:32:35                  slot_type, slot, [this](MaybeObject** slot) {
10:32:35                                        ^
10:32:35 ../../src/heap/mark-compact.cc: In instantiation of ‘struct v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MajorNonAtomicMarkingState; v8::internal::Address = long unsigned int]::<lambda(class v8::internal::MaybeObject**)>’:
10:32:35 ../../src/heap/mark-compact.cc:2861:58:   required from ‘v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MajorNonAtomicMarkingState; v8::internal::Address = long unsigned int]’
10:32:35 ../../src/heap/mark-compact.cc:2860:20:   required from ‘struct v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers() [with MarkingState = v8::internal::MajorNonAtomicMarkingState]::<lambda(enum v8::internal::SlotType, v8::internal::Address, v8::internal::Address)>’
10:32:35 ../../src/heap/mark-compact.cc:2859:46:   required from ‘void v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers() [with MarkingState = v8::internal::MajorNonAtomicMarkingState]’
10:32:35 ../../src/heap/mark-compact.cc:2770:24:   required from ‘void v8::internal::RememberedSetUpdatingItem<MarkingState>::Process() [with MarkingState = v8::internal::MajorNonAtomicMarkingState]’
10:32:35 ../../src/heap/mark-compact.cc:4315:1:   required from here
10:32:35 ../../src/heap/mark-compact.cc:2862:39: error: ‘v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MajorNonAtomicMarkingState; v8::internal::Address = long unsigned int]::<lambda(v8::internal::MaybeObject**)>’ declared with greater visibility than the type of its field ‘v8::internal::RememberedSetUpdatingItem<MarkingState>::UpdateTypedPointers()::<lambda(v8::internal::SlotType, v8::internal::Address, v8::internal::Address)> [with MarkingState = v8::internal::MajorNonAtomicMarkingState; v8::internal::Address = long unsigned int]::<lambda(v8::internal::MaybeObject**)>::<this capture>’ [-Werror=attributes]
10:32:35 cc1plus: all warnings being treated as errors

Additional information

Going to try bisecting v10.x releases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions