Repository navigation
console.timeEnd shouldn't throw if there is no matching label #3514
Description
There is a test expecting that behavior, but it probably isn't a sensible behavior.
A better behavior would be to fail silently while printing a message to stderr saying there is no corresponding label.
Activity
cjihrig commentedon Oct 25, 2015
I'm not saying the current behavior is write or wrong, but it looks like it's been that way for quite a while.
Seems that Chrome does not throw in a similar situation.
DavidBruant commentedon Oct 25, 2015
Neither does Firefox AFAICT
mscdex commentedon Oct 25, 2015
If we're going to use Chrome and Firefox as models, then we should just ignore invalid labels and not print anything.
cjihrig commentedon Oct 25, 2015
@bnoordhuis do you remember the original purpose for throwing (it looks like you landed the commit)?
We would still have to assume that someone, somewhere is relying on that exception being thrown, and treat this as a semver major change
jasnell commentedon Apr 27, 2016
Fixed in #5901