n-api: does napi_create_external_buffer copy?

[mafintosh]

Hunting down a bug related to napi_create_external_buffer, I got a bit confused by reading the docs here:

https://nodejs.org/dist/latest-v14.x/docs/api/n-api.html#n_api_napi_create_external_buffer

[in] data: Raw pointer to the underlying buffer to copy from.

Does this mean that the buffer is created with the same pointer or a new pointer that's a memcopy?

Further down on the docs for the same method it also says:

This API allocates a node::Buffer object and initializes it with data backed by the passed in buffer.

Which I'm also not sure wheather to interpret as a memcopy

[mafintosh]

Did some testing and it seems to be not memcopying it. If other people agree that this is the correct behaivour and that the docs are confusing I can volunteer a PR

[addaleax]

Yes, this is an error in the docs, it does not copy (and there would be no point in doing so for externalized buffers anyway).

[mhdawson]

@mafintosh a PR for the docs would be great.