-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.parent and .offset of Buffer and SlowBuffer .prototype throw an exception when accessed #3297
Labels
buffer
Issues and PRs related to the buffer subsystem.
Comments
wraithan
changed the title
.parent and .offset of Buffer and SlowBuffer .prototype throw an exception when accessed:
.parent and .offset of Buffer and SlowBuffer .prototype throw an exception when accessed
Oct 9, 2015
trevnorris
added a commit
to trevnorris/node
that referenced
this issue
Oct 9, 2015
Accessing prototype properties directly on a typed array will throw. So do an extra check in Buffer's own getters to verify it is being called on an instance. Fixes: nodejs#3297
Posted fix, running CI. |
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was writing a tool to scrape the APIs of everything and stumbled across these in the buffer module.
Repro:
Run the following JS on any version of node/io.js from 3.0.0 until 4.1.2 (current as of time of writing)
Example output:
CCing @trevnorris since he asked me to.
The text was updated successfully, but these errors were encountered: