Skip to content

n-api: napi_make_callback with async_hooks.executionAsyncResource #32898

Closed
Closed
n-api: napi_make_callback with async_hooks.executionAsyncResource#32898
Assignees
legendecas
Labels
async_hooksIssues and PRs related to the async hooks subsystem.node-apiIssues and PRs related to Node-API.

Description

@legendecas
legendecas
opened on Apr 17, 2020
  • Version: n-api v6/ v14.0.0-pre
  • Platform: all
  • Subsystem: n-api, async_hooks

During the callback of napi_make_callback, async_hooks.executionAsyncResource() doesn't reflect the resource object of the given async_context. Rather, it's the receiver of napi_make_callback.

Activity

  1. legendecas
    added
    async_hooksIssues and PRs related to the async hooks subsystem.
    node-apiIssues and PRs related to Node-API.
    on Apr 17, 2020
  2. legendecas
    self-assigned this
    on Apr 17, 2020

  3. puzpuzpuz commented on Apr 17, 2020

    @puzpuzpuz
    puzpuzpuz
    on Apr 17, 2020
    Member

    Do you mean async_hooks.executionAsyncResource() by async_hooks.executionResource or it's something different?

  4. legendecas commented on Apr 17, 2020

    @legendecas
    legendecas
    on Apr 17, 2020
    MemberAuthor

    Do you mean async_hooks.executionAsyncResource() by async_hooks.executionResource or it's something different?

    Yes, it’s async_hooks.executionAsyncResource(). Updated.

  5. legendecas
    changed the title [-]n-api: napi_make_callback with async_hooks.executionResource[/-] [+]n-api: napi_make_callback with async_hooks.executionAsyncResource[/+] on Apr 17, 2020

  6. puzpuzpuz commented on Apr 17, 2020

    @puzpuzpuz
    puzpuzpuz
    on Apr 17, 2020
    Member

    Yes, it’s async_hooks.executionAsyncResource(). Updated.

    Good to know. Then this issue may be of some interest for @Qard

  7. Qard commented on Apr 20, 2020

    @Qard
    Qard
    on Apr 20, 2020
    Member

    Yep. This is a known issue. Could maybe be fixed here by attempting an unwrap to an AsyncWrap and using the GetResource() method. 🤔

  8. legendecas commented on Apr 21, 2020

    @legendecas
    legendecas
    on Apr 21, 2020
    MemberAuthor

    @Qard #32930 I submitted a PR to wrap the N-API async context similar to AsyncWrap. (In the case, AsyncWrap is not suitable since the resource object in the N-API may have no internal slot, which fails the BaseObject's assertion)

  9. nodejs-github-bot
    closed this as completedin 3a7537don Oct 31, 2020
  10. BethGriggs
    added 4 commits that reference this issue on Dec 8, 2020

    n-api: napi_make_callback emit async init with resource of async_context

    8195365

    n-api: napi_make_callback emit async init with resource of async_context

    a939c95

    n-api: napi_make_callback emit async init with resource of async_context

    1cb50c1
  11. MayaLekova
    added a commit that references this issue on May 22, 2026

    n-api: napi_make_callback emit async init with resource of async_context

    3a7537d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

async_hooksIssues and PRs related to the async hooks subsystem.node-apiIssues and PRs related to Node-API.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions