-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Closed
Labels
bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.
Description
Refs: #31399
Audit src/node_buffer.cc, lib/buffer.js and lib/internal/buffer.js - there are places where assumptions are made about the type of indices, e.g.:
Lines 593 to 596 in 3ff2aec
| uint32_t start; | |
| if (!args[2]->Uint32Value(ctx).To(&start)) return; | |
| uint32_t end; | |
| if (!args[3]->Uint32Value(ctx).To(&end)) return; |
I suspect most C++ code can be switched over to ParseArrayIndex().
Metadata
Metadata
Assignees
Labels
bufferIssues and PRs related to the buffer subsystem.Issues and PRs related to the buffer subsystem.lib / srcIssues and PRs related to general changes in the lib or src directory.Issues and PRs related to general changes in the lib or src directory.