fs.mkdir/mkdirSync recursive hang with invalid windows character

Hi,

The following issue: #28599 doesn't seem to be resolved. I just encountered the problem on a project i work on since few days where we generate reports (some reports name has the ':' symbol in the name which is not good... i guess my collaborators are not working on Windows 😅)

Version: Node.js 13.3.0
Platform: Windows 10 - 64 Bit

How to reproduce (work with mkdirSync and mkdir promises):

const { mkdirSync } = require("fs");

console.log("A");
mkdirSync("test:lol", { recursive: true });
console.log("B");

mkdirSync never return. This should throw an Error.

Best Regards,
Thomas

@cjihrig

@cjihrig @bcoe

@bzoz

Were the @ mentions because of recursive rmdir() (not mkdir()), or something else?

Also cc: @bzoz (for working on #28599).

@cjihrig

Were the @ mentions because of recursive rmdir() (not mkdir()), or something else?

@cjihrig In your case, I @-mentioned you because the linked issue (#28599) was closed by #29070, which you authored, so I thought you might have insight as to what's going on here. (I didn't look too closely at things. Sorry if the ping was a bit over-eager of me.)

@addaleax

@addaleax is there any reason we can't upstream this libuv patch into Node?

@bcoe

@bcoe I think that libuv patch is already included in the relevant Node.js versions, so it’s probably a different (?) issue? I can try to check the next time I’m on Windows.

I'm trying to debug with visual studio (first time :D). The value of err for the invalid path here is UV_ENOENT. It then reaches the condition dirname != next_path, which is true so it adds dirname and next_path to the queue.
Then dirname is handled (it exists).
Then next_path is handled, and we're back to the previous behavior -> infinite loop

Please review libuv/libuv#2601

win, fs: mkdir really return UV_EINVAL for invalid names

This was already fixed in libuv and released in libuv@1.41.0.

Navigation Menu

Repository navigation

fs.mkdir/mkdirSync recursive hang with invalid windows character #31177

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

fs.mkdir/mkdirSync recursive hang with invalid windows character #31177

Description

Activity

Trott commented on Jan 4, 2020

cjihrig commented on Jan 4, 2020

Trott commented on Jan 4, 2020

bcoe commented on Jan 5, 2020

addaleax commented on Jan 5, 2020

targos commented on Jan 5, 2020

vtjnash commented on Aug 18, 2020

santigimeno commented on Nov 14, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions