Repository navigation
Flaky parallel/test-repl-history-navigation #31094
Description
Activity
- addedreplIssues and PRs related to the REPL subsystem.Issues and PRs related to the REPL subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.
on Dec 25, 2019 This seems easy to reproduce by changing
common.platformTimeout(40)tocommon.platformTimeout(400)in the test.Is there a chance we could remove the timeouts entirely? There shouldn’t be any in a REPL test, I think.
@addaleax we never specified if a custom completion function may be async or not. Right now async is accepted and if someone types fast the completion could be triggered multiple times. In that case only the very last triggered completion should be accepted. We could pause the stream during the completion instead of using a counter but it's not possible to keep on typing while the completion is running in that case.
@BridgeAR I assumed that completion functions may be async, but I don’t understand why that would need to be modelled though timers in the test?
- added a commit that references this issue
on Feb 17, 2020 - added 2 commits that reference this issue
on Apr 25, 2020
I added this test recently and it actually checks a race condition. Seems like the test itself is not solid enough tough.