Skip to content

display node.js version (process.version) at the end of stacktraces #29731

Closed
Closed
display node.js version (process.version) at the end of stacktraces#29731
Labels
errorsIssues and PRs related to JavaScript errors originating in Node.js core.feature requestIssues requesting new Node.js features.

Description

@ORESoftware
ORESoftware
opened on Sep 27, 2019

This could be added with a flag, and later turned off with a flag if you don't want to see it.

with this in mind:
nodejs/help#2204

the current stacktrace is:

SyntaxError: Invalid or unexpected token
at Module._compile (internal/modules/cjs/loader.js:723:23)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)

it would be interesting if it looked like:

SyntaxError: Invalid or unexpected token
at Module._compile (internal/modules/cjs/loader.js:723:23)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Function.Module.runMain (internal/modules/cjs/loader.js:831:12)
at startup (internal/bootstrap/node.js:283:19)
at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
via node.js version: 12.3.4

or whatever

just an idea, not sure if it's possible/desirable to implement

Activity

  1. boneskull commented on Sep 27, 2019

    @boneskull
    boneskull
    on Sep 27, 2019
    Member

    @ORESoftware Is there a precedent for this anywhere?

  2. ORESoftware commented on Sep 27, 2019

    @ORESoftware
    ORESoftware
    on Sep 27, 2019
    ContributorAuthor

    not sure if there is a precedent but it would be a nice feature. it does make stack traces noisier though. so maybe a flag to switch it on/off.

  3. mhdawson commented on Sep 30, 2019

    @mhdawson
    mhdawson
    on Sep 30, 2019
    Member

    If you enable --experimental-report --report-uncaught-exception you would get the node version and much more. Having said that it's still and interesting idea.

  4. Fishrock123 commented on Oct 1, 2019

    @Fishrock123
    Fishrock123
    on Oct 1, 2019
    Contributor

    I dunno, if you don't know what node binary you are running that seems like an issue in itself not really solvable by us.

  5. ORESoftware commented on Oct 1, 2019

    @ORESoftware
    ORESoftware
    on Oct 1, 2019
    ContributorAuthor

    @Fishrock123 it's primarily for helping people online when they post stack traces, but even at work I switch between node.js versions and don't always recall or consider which one I am using etc.

  6. gireeshpunathil commented on Dec 26, 2019

    @gireeshpunathil
    gireeshpunathil
    on Dec 26, 2019
    Member

    IMO printing the node.js version in stack trace is good, although it addresses a minimal subset of problem determination through FFDC (first failure data capture). For example, on a similar ground I can see that openssl version, javascript heap size , command line that was passed etc. can also solve another class of problems. So diagnostic report looks to be the right approach here?

  7. ORESoftware commented on Mar 23, 2020

    @ORESoftware
    ORESoftware
    on Mar 23, 2020
    ContributorAuthor

    this is a very useful feature, useful for a thousand github issues, like this one most likely: ORESoftware/live-mutex#92 (comment)

  8. juanarbol commented on Mar 27, 2020

    @juanarbol
    juanarbol
    on Mar 27, 2020
    Member

    @ORESoftware Diagnostic report is now stable, you should consider using it for this case.

  9. ORESoftware commented on Mar 27, 2020

    @ORESoftware
    ORESoftware
    on Mar 27, 2020
    ContributorAuthor

    the user case here is for stack traces in general, so you dont have to ask "what node version are you on?" sometimes its easy to forget to ask

  10. targos
    added
    errorsIssues and PRs related to JavaScript errors originating in Node.js core.
    feature requestIssues requesting new Node.js features.
    on Dec 26, 2020

  11. theoludwig commented on Apr 21, 2021

    @theoludwig
    theoludwig
    on Apr 21, 2021
    Contributor

    the user case here is for stack traces in general, so you dont have to ask "what node version are you on?" sometimes its easy to forget to ask

    Indeed, I think it is a nice thing to have the Node.js version at the end of stacktraces, I opened a PR to implement that: #38332

  12. Fishrock123 commented on May 18, 2021

    @Fishrock123
    Fishrock123
    on May 18, 2021
    Contributor

    My stance on this has changed. Print that stuff. Not that i have any say here, but hey. (Also, unsubscribing.)

  13. danielleadams commented on Jun 9, 2021

    @danielleadams
    danielleadams
    on Jun 9, 2021
    Contributor

    Maybe a topic for a different issue, but does it make sense to include a link to the API documentation for the version too? It may bloat the stack trace even more, but discoverability of API docs for different versions can be confusing and it could help remove a couple steps before opening an Issue or SO question. (ie. https://nodejs.org/dist/v14.17.0/docs/api/)

  14. mhdawson commented on Jun 9, 2021

    @mhdawson
    mhdawson
    on Jun 9, 2021
    Member

    @danielleadams I'd be worried that that link might change, we currently have nodejs.org and nodejs.dev and its not impossible that we might change doc structure. Having the version should make it relatively easy to find the right version of the API docs.

  15. mhdawson
    closed this as completedin 59d3d54on Sep 8, 2021

  16. ORESoftware commented on Feb 3, 2022

    @ORESoftware
    ORESoftware
    on Feb 3, 2022
    ContributorAuthor

    was this implemented or is it still only behind a node flag?

  17. theoludwig commented on Feb 3, 2022

    @theoludwig
    theoludwig
    on Feb 3, 2022
    Contributor

    was this implemented or is it still only behind a node flag?

    Yes it is available on Node.js >= v17.0.0, no flag required (but you can disable it with a flag). @ORESoftware

  18. MayaLekova
    added a commit that references this issue on May 22, 2026

    errors: disp ver on fatal except that causes exit

    59d3d54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    errorsIssues and PRs related to JavaScript errors originating in Node.js core.feature requestIssues requesting new Node.js features.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions