Skip to content

deps: need to cherrypick async fix into inspector code generator #29548

Closed
@cclauss

Description

@cclauss

An 'async' is a reserved word in Python >= 3.7 fix has been landed upstream at https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351

That change needs to be downstreamed into deps/v8/third_party/inspector_protocol/code_generator.py because python3.7 ./configure.py ; NODE=$(which node) make test still fails as discussed in #29326

#29346 and #29520 attempted to do this but were rejected for various reasons but this needs to be completed. The problem with #29520 is that it did not follow the tool-based process but that process is based on the change being mirrored into https://github.com/v8/v8/blob/master/third_party/inspector_protocol/code_generator.py but that is not the upstream repo that was modified.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions