Repository navigation
deps: need to cherrypick async fix into inspector code generator #29548
Description
Activity
third_party/inspector_protocolin upstream V8 gets updated every once in a while. No action on our side is necessary, we can just float the patch locally until upstream syncs up with its upstream.Reacted by Michaël Zasso- added a commit that references this issue
on Sep 25, 2019 - added a commit that references this issue
on Sep 27, 2019 - added 2 commits that reference this issue
on Jan 7, 2020 - added a commit that references this issue
on Feb 6, 2020 - added a commit that references this issue
on Jul 27, 2026
Metadata
Metadata
Assignees
Labels
No labels
An 'async' is a reserved word in Python >= 3.7 fix has been landed upstream at https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1781351
That change needs to be downstreamed into deps/v8/third_party/inspector_protocol/code_generator.py because python3.7 ./configure.py ; NODE=$(which node) make test still fails as discussed in #29326
#29346 and #29520 attempted to do this but were rejected for various reasons but this needs to be completed. The problem with #29520 is that it did not follow the tool-based process but that process is based on the change being mirrored into https://github.com/v8/v8/blob/master/third_party/inspector_protocol/code_generator.py but that is not the upstream repo that was modified.