Closed
Description
-
error
can be emitted afterclose
-
write after end
-
invalid argument
-
-
open
can be emitted aftererror
- does not use
errorOrDestroy
onclose()
- should not emit
error
, useerrorOrDestroy
or callback. -
_write
does an unnecessary check forinstanceof Buffer
(fs: unecessary argument validation #29043). - calling write before fd and closing, will cause write to happen on destroyed stream (i.e. flush after destroy)
- don't use
end()
instead ofdestroy()
. Keep track of pendingcb instead. (related issue stream: Writable should not invoke _destroy while pending ops #29044) - emit 'close' on destroy
- emit 'close' close error
Metadata
Metadata
Assignees
Labels
No labels