http: responseKeepAlive incorrect usage of finished?

[ronag]

Having a hard time to wrap my head around this one. But this looks like a potential bug:

https://github.com/nodejs/node/blob/master/lib/_http_client.js#L621

It seems to assume that if req.finished is true then prefinish has been emitted (or all data has been flushed) and frees the socket for re-use even though more data might be written to it. req.finished just means that end() has been called, not that no more data is going to be written to the socket.

I'm not sure if this is actually a problem. Haven't been able to create any sensible repo case that fails. But it looks very suspect...

[ronag]

@benjamingr Who can I ping on this one? It's a rather tricky one...

[ronag]

Although confusing this is probably fine. responseOnEnd is only called if a socket has been assigned and if a socket is assigned then all data is directly passed to the socket.

[ronag]

Added a description in https://github.com/nodejs/node/pull/28700/files#diff-e3bc37430eb078ccbafe3aa3b570c91aR621 for the next adventurer.