Skip to content

http2/compat: undocumented public property "complete" #28622

Closed
@ronag

Description

@ronag

The Http2ServerRequest has an undocumented public property "complete".

I guess it should be either be documented or made private? What is it's purpose? Should we add it to http/1?

  get complete() {
    return this._readableState.ended ||
           this[kState].closed ||
           this[kStream].destroyed;
  }

I'm not sure where this property is useful over just checking this[kState].closed? Seems like some kind of hybrid property of streams being closed and the old http/1 finished semantics.

I guess it is true if end() has been called OR 'close' has been emitted?

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to the documentations.http2Issues or PRs related to the http2 subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions