Certificate issues on the custom-suites-freestyle CI

[BridgeAR]

A couple of tests consistently fail on our custom-suites-freestyle CI.

• test.parallel/test-https-client-reject
• test.parallel/test-https-pfx
• test.parallel/test-tls-client-reject
• test.parallel/test-tls-client-reject-12
• test.parallel/test-tls-connect-no-host

See e.g., https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/7863/#showFailuresLink

I can't look into it right now, so @nodejs/build @nodejs/crypto PTAL

[bnoordhuis]

Maybe not relevant but this shows up in the build log:

18:16:46 python ./configure --verbose 
18:16:47 WARNING: C++ compiler too old, need g++ 6.3.0 or clang++ 8.0.0 (CXX=ccache g++)

Is there anything else that's unusual about this machine?

[cjihrig]

I thought @sam-github fixed this recently too?

[sam-github]

I don't think so, I did some ubuntu14.04 maintenance on IBM platforms, but I don't think I did anything for 1604 on x86, and I just scanned my PRs into nodejs/build, nothing seems relevant.

[richardlau]

@sam-github I think @cjihrig was referring to the PR that fixed up the test fixture certificates validity dates (#28473). Perhaps the failures are for PR's that need to be rebased to pick up the fixed fixtures (although if that was the case we'd probably expect the failures to show up in other jobs too (unless there's something different about the way this job rebases))?

[addaleax]

I think this is a build infra issue, otherwise this wouldn’t be failing on just one machine, right?

[richardlau]

(unless there's something different about the way this job rebases))?

It's most probably related to nodejs/build#1790.

[richardlau]

This has been fixed (nodejs/build#1790 (comment)). The job in question was not calling the script that rebases the PR on top of the current master branch correctly.