RangeError: Maximum call stack size exceeded when attempting to push a big list into another list

[iJadric]

• Version: 10.15.3
• Platform: Linux AMI
• Subsystem:

When attempting to push a list of size 100k + into another list, Node.js throws RangeError: Maximum call stack size exceeded.

Sample code is

let reallyBigList = ..... (100k + elements)
this.instanceList.push(...reallyBigList);

I don't know if this is meant to be

[Hakerh400]

That's not a bug. Spread call stores all arguments on the V8 stack. Firefox gives better message though: "RangeError: too many function arguments". Array.prototype.push is not supposed to be called with a large number of arguments. You can push elements in a loop, or use Array.prototype.concat. Improving this error message was discussed in the past (like v8/v8#7031), but it is marked as low priority.

[devsnek]

Please re-open if you feel there is something actionable for node to do here.