Repository navigation
dns.lookup() documentation error code #27604
Description
- Version: v11.15.0
- Platform: N/A
- Subsystem: N/A
The nodejs documentation for dns.lookup() seems to imply that the error will ENOENT, if a domain is not found. Should this be ENOTFOUND instead?
https://nodejs.org/docs/latest-v11.x/api/dns.html#dns_dns_lookup_hostname_options_callback
"On error, err is an Error object, where err.code is the error code. Keep in mind that err.code will be set to 'ENOENT' not only when the hostname does not exist but also when the lookup fails in other ways such as no available file descriptors."
Activity
Trott commentedon May 8, 2019
I'm certainly getting
ENOTFOUNDlocally whendns.lookup()fails to find an address. And it's also what I get for valid names if I setulimit -nsufficiently low. So it sure seems to be the case thatENOTFOUNDmight sometimes mean "no available file descriptors" (or at least something that isn't actually "address not found") in this case, which is really unfortunate IMO. EDIT: I'm on macOS, just in case this is platform-dependent behavior.sagitsofan commentedon May 9, 2019
It seems that
dns.lookup()will always returnENOTFOUNDon a empty lookup or when the host not found.https://github.com/nodejs/node/blob/master/lib/internal/errors.js#L503
Should we change the error code or fixed the documentation?
Trott commentedon May 13, 2019
Fixed in fd8d5e7
doc: dns.lookup() documentation error code
doc: dns.lookup() documentation error code