[8.x] assert.rejects fails with confusing error message

[gcampax]

• Version: latest 8.* series
• Platform: not relevant
• Subsystem: assert

The API of assert.rejects is different between the 10.* series and the 8.* series, because the backported 8.* version does not accept a Promise as first argument, it requires a Function that returns a rejected promise.
If you misuse the API, though, you get a confusing error message:

TypeError: errors.ERR_INVALID_ARG_TYPE is not a constructor
at waitForActual (assert.js:723:11)
at Function.rejects (assert.js:799:31)

This is because at

node/lib/assert.js

Line 723 in 045868d

throw new errors.ERR_INVALID_ARG_TYPE('block', 'Function', block);

the throw line is incorrect.

[BridgeAR]

Hm, yes. In Node.js v8 we do not have the new Error system and we did not see that while backporting.

I'll try to get a fix into v8.16.0 (#26933).

[MylesBorins]

Fix went out in 8.16.0