Repository navigation
investigate flaky test-worker-ref-onexit #26167
Copy link
Copy link
Closed
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.workerIssues and PRs related to the worker_threads module and Worker API.Issues and PRs related to the worker_threads module and Worker API.
Description
Activity
- addedtestIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.workerIssues and PRs related to the worker_threads module and Worker API.Issues and PRs related to the worker_threads module and Worker API.
on Feb 17, 2019 See also #26083 (comment) … if this is an AIX-specific problem (which I guess it could be?), I’m not sure how to best debug it.
One idea could be that the Worker finishes before the current event loop turn is over. Something like this might fix it?
diff --git a/test/parallel/test-worker-ref-onexit.js b/test/parallel/test-worker-ref-onexit.js index 0250c592ce91..968f0fe31e9e 100644 --- a/test/parallel/test-worker-ref-onexit.js +++ b/test/parallel/test-worker-ref-onexit.js @@ -5,6 +5,6 @@ const { Worker } = require('worker_threads'); // Check that worker.unref() makes the 'exit' event not be emitted, if it is // the only thing we would otherwise be waiting for. -const w = new Worker('', { eval: true }); +const w = new Worker('while(true);', { eval: true }); w.unref(); w.on('exit', common.mustNotCall());
AIX stress test with 1000 runs: https://ci.nodejs.org/job/node-stress-single-test/2157/ (failed 34/267)
Edit: Stress test with proposed solution: https://ci.nodejs.org/job/node-stress-single-test/2158/- added a commit that references this issue
on Feb 17, 2019 - added a commit that references this issue
on Feb 18, 2019 - added a commit that references this issue
on Feb 28, 2019 - added a commit that references this issue
on Jul 27, 2026
Metadata
Metadata
Assignees
Labels
flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.workerIssues and PRs related to the worker_threads module and Worker API.Issues and PRs related to the worker_threads module and Worker API.
Haven't seen this one before. Might be difficult to reproduce (but I haven't tried yet).
https://ci.nodejs.org/job/node-test-commit-aix/21132/nodes=aix61-ppc64/console
test-osuosl-aix61-ppc64_be-1